From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2CF691B6DB; Thu, 10 Jan 2019 14:27:29 +0100 (CET)
In-Reply-To: <20190110132625.118111-1-cristian.dumitrescu@intel.com>
References: <20190110132625.118111-1-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20190110132729.2CF691B6DB@dpdk.org>
Date: Thu, 10 Jan 2019 14:27:29 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw49584 [v3] net/softnic: add support
	for service cores
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 13:27:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49584

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->enabled'
#168: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:118:
+		if ((pipeline->enabled) && (pipeline->thread_id == thread_id))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->thread_id == thread_id'
#168: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:118:
+		if ((pipeline->enabled) && (pipeline->thread_id == thread_id))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#217: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:105:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(thread_id == cfg->master_lcore))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id == cfg->master_lcore'
#217: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:105:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(thread_id == cfg->master_lcore))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'role == ROLE_SERVICE'
#223: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:111:
+	if ((softnic->params.sc && (role == ROLE_SERVICE)) ||
+		(!softnic->params.sc && (role == ROLE_RTE)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'role == ROLE_RTE'
#223: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:111:
+	if ((softnic->params.sc && (role == ROLE_SERVICE)) ||
+		(!softnic->params.sc && (role == ROLE_RTE)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#325: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#325: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#325: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#325: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_pipelines == 0'
#341: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:313:
+	if (softnic->params.sc && (n_pipelines == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#374: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:395:
+	if (!thread_is_valid(softnic, thread_id) ||
+		(p == NULL) ||
+		(p->enabled && (p->thread_id != thread_id)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->thread_id != thread_id'
#374: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:395:
+	if (!thread_is_valid(softnic, thread_id) ||
+		(p == NULL) ||
+		(p->enabled && (p->thread_id != thread_id)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'td->n_pipelines == 0'
#392: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:432:
+		if (softnic->params.sc && (td->n_pipelines == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_pipelines == 0'
#403: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:465:
+	if (softnic->params.sc && (n_pipelines == 0))

total: 0 errors, 0 warnings, 15 checks, 370 lines checked