From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D38765B3E; Tue, 15 Jan 2019 14:29:41 +0100 (CET)
In-Reply-To: <20190115133041.17556-1-qi.z.zhang@intel.com>
References: <20190115133041.17556-1-qi.z.zhang@intel.com>
To: test-report@dpdk.org
Cc: Qi Zhang <qi.z.zhang@intel.com>
Message-Id: <20190115132941.D38765B3E@dpdk.org>
Date: Tue, 15 Jan 2019 14:29:41 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw49842 [RFC] net/ice: enable package
	download and RSS
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jan 2019 13:29:42 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49842

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#67: FILE: drivers/net/ice/ice_ethdev.c:1269:
+	file = fopen("ice_os_default.pkg","rb");
 	                                 ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#123: FILE: drivers/net/ice/ice_ethdev.c:1381:
+	if (ret) {
+		PMD_INIT_LOG(ERR, "Failed to load default OS package");
+	}

ERROR:SPACING: space required after that ',' (ctx:VxV)
#137: FILE: drivers/net/ice/ice_ethdev.c:1622:
+		PMD_DRV_LOG(ERR, "%s TCP_IPV4 rss flow fail %d",__func__, ret);
 		                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#142: FILE: drivers/net/ice/ice_ethdev.c:1627:
+		PMD_DRV_LOG(ERR, "%s UDP_IPV4 rss flow fail %d",__func__, ret);
 		                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#147: FILE: drivers/net/ice/ice_ethdev.c:1632:
+		PMD_DRV_LOG(ERR, "%s SCTP_IPV4 rss flow fail %d",__func__, ret);
 		                                                ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#152: FILE: drivers/net/ice/ice_ethdev.c:1637:
+		PMD_DRV_LOG(ERR, "%s TCP_IPV6 rss flow fail %d",__func__, ret);
 		                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#157: FILE: drivers/net/ice/ice_ethdev.c:1642:
+		PMD_DRV_LOG(ERR, "%s UDP_IPV6 flow fail %d",__func__, ret);
 		                                           ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#162: FILE: drivers/net/ice/ice_ethdev.c:1647:
+		PMD_DRV_LOG(ERR, "%s SCTP_IPV6 rss flow fail %d",__func__, ret);
 		                                                ^

total: 7 errors, 1 warnings, 0 checks, 125 lines checked