From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ola Liljedahl <Ola.Liljedahl@arm.com>
Subject: [dpdk-test-report] |WARNING| pw50095 [RFC, v2] lfring: lock-free ring buffer
Date: Wed, 30 Jan 2019 17:36:54 +0100 (CET) [thread overview]
Message-ID: <20190130163654.EBB2B1B3B6@dpdk.org> (raw)
In-Reply-To: <1548866179-20766-1-git-send-email-ola.liljedahl@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50095
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#33:
some other thread wrote the slot and the thread continues with the next slot.
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'cmpxchg16b', this function's name, in a string
#266: FILE: lib/librte_lfring/lockfree16.h:99:
+ ("lock cmpxchg16b %1
setz %0"
ERROR:SPACING: space prohibited after that '&' (ctx:WxW)
#928: FILE: lib/librte_lfring/rte_lfring.h:330:
+ struct rte_lfr_element *slot = &r->ring[tail & mask];
^
ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#932: FILE: lib/librte_lfring/rte_lfring.h:334:
+ if (old.e.lap != (tail - size) >> r->log2) {
^
ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1029: FILE: lib/librte_lfring/rte_lfring.h:431:
+ actual = RTE_MIN((int64_t)(tail - head), (int64_t)nelems);
^
ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1039: FILE: lib/librte_lfring/rte_lfring.h:441:
+ *available = tail - (head + actual);
^
ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1059: FILE: lib/librte_lfring/rte_lfring.h:461:
+ actual = RTE_MIN((int64_t)(tail - head), (int64_t)nelems);
^
ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1073: FILE: lib/librte_lfring/rte_lfring.h:475:
+ *available = tail - (head + actual);
^
ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1116: FILE: lib/librte_lfring/rte_lfring.h:518:
+ uint64_t avail = tail - head;
^
total: 7 errors, 2 warnings, 1094 lines checked
parent reply other threads:[~2019-01-30 16:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1548866179-20766-1-git-send-email-ola.liljedahl@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130163654.EBB2B1B3B6@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=Ola.Liljedahl@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).