From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id EBB2B1B3B6; Wed, 30 Jan 2019 17:36:54 +0100 (CET)
In-Reply-To: <1548866179-20766-1-git-send-email-ola.liljedahl@arm.com>
References: <1548866179-20766-1-git-send-email-ola.liljedahl@arm.com>
To: test-report@dpdk.org
Cc: Ola Liljedahl <Ola.Liljedahl@arm.com>
Message-Id: <20190130163654.EBB2B1B3B6@dpdk.org>
Date: Wed, 30 Jan 2019 17:36:54 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw50095 [RFC,
	v2] lfring: lock-free ring buffer
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2019 16:36:55 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50095

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#33: 
some other thread wrote the slot and the thread continues with the next slot.

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'cmpxchg16b', this function's name, in a string
#266: FILE: lib/librte_lfring/lockfree16.h:99:
+		("lock cmpxchg16b %1
	setz %0"

ERROR:SPACING: space prohibited after that '&' (ctx:WxW)
#928: FILE: lib/librte_lfring/rte_lfring.h:330:
+		struct rte_lfr_element *slot = &r->ring[tail & mask];
 		                                             ^

ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#932: FILE: lib/librte_lfring/rte_lfring.h:334:
+			if (old.e.lap != (tail - size) >> r->log2) {
 			                       ^

ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1029: FILE: lib/librte_lfring/rte_lfring.h:431:
+	actual = RTE_MIN((int64_t)(tail - head), (int64_t)nelems);
 	                                ^

ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1039: FILE: lib/librte_lfring/rte_lfring.h:441:
+		*available = tail - (head + actual);
 		                  ^

ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1059: FILE: lib/librte_lfring/rte_lfring.h:461:
+		actual = RTE_MIN((int64_t)(tail - head), (int64_t)nelems);
 		                                ^

ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1073: FILE: lib/librte_lfring/rte_lfring.h:475:
+		*available = tail - (head + actual);
 		                  ^

ERROR:SPACING: space prohibited after that '-' (ctx:WxW)
#1116: FILE: lib/librte_lfring/rte_lfring.h:518:
+	uint64_t avail = tail - head;
 	                      ^

total: 7 errors, 2 warnings, 1094 lines checked