automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Fan Zhang <roy.fan.zhang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw50378 fips_validation: Add plain SHA support
Date: Tue, 19 Feb 2019 16:56:47 +0100 (CET)	[thread overview]
Message-ID: <20190219155647.1EF4D1B1D6@dpdk.org> (raw)
In-Reply-To: <20190219155450.4492-1-roy.fan.zhang@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50378

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#190: FILE: examples/fips_validation/fips_validation_sha.c:41:
+			parser_read_uint32_val(ALGO_PREFIX, text, &vec.cipher_auth.digest);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#247: FILE: examples/fips_validation/fips_validation_sha.c:98:
+		if (strstr(line, MCT_STR)) {
+			info.interim_info.sha_data.test_type = SHA_MCT;
+		}

WARNING:LONG_LINE: line over 90 characters
#344: FILE: examples/fips_validation/main.c:1289:
+			memcpy((vec.pt.val + md[0].len + md[1].len), md[2].val, (size_t)md[2].len);

WARNING:LONG_LINE: line over 90 characters
#363: FILE: examples/fips_validation/main.c:1308:
+			memcpy(md[2].val, (val.val + vec.pt.len), vec.cipher_auth.digest.len);

total: 0 errors, 4 warnings, 343 lines checked

           reply	other threads:[~2019-02-19 15:56 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190219155450.4492-1-roy.fan.zhang@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219155647.1EF4D1B1D6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=roy.fan.zhang@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).