From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C5C3C1E34; Wed, 20 Feb 2019 12:54:55 +0100 (CET)
In-Reply-To: <20190220115254.18724-1-jgrajcia@cisco.com>
References: <20190220115254.18724-1-jgrajcia@cisco.com>
To: test-report@dpdk.org
Cc: Jakub Grajciar <jgrajcia@cisco.com>
Message-Id: <20190220115455.C5C3C1E34@dpdk.org>
Date: Wed, 20 Feb 2019 12:54:55 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw50385 [RFC,
	v4] /net: memory interface (memif)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2019 11:54:55 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50385

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#530: FILE: drivers/net/memif/memif.h:134:
+typedef struct __rte_packed __rte_aligned(128) {

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1122: FILE: drivers/net/memif/memif_socket.c:542:
+				ret = rte_intr_callback_unregister_pending(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1339: FILE: drivers/net/memif/memif_socket.c:759:
+	dev = rte_eth_dev_allocated(rte_vdev_device_name(

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1846: FILE: drivers/net/memif/rte_eth_memif.c:39:
+static const char *valid_arguments[] = {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2795: FILE: drivers/net/memif/rte_eth_memif.c:988:
+	if (ret != 6) {
+		MIF_LOG(WARNING, "Failed to parse mac '%s'.", value);
+	}

total: 1 errors, 2 warnings, 3012 lines checked