From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: [dpdk-test-report] |WARNING| pw50433 [RFC, v3, 2/5] test/rcu_qsbr: add API and functional tests
Date: Fri, 22 Feb 2019 08:06:51 +0100 (CET) [thread overview]
Message-ID: <20190222070651.2EFFF2BF4@dpdk.org> (raw)
In-Reply-To: <20190222070427.22866-3-honnappa.nagarahalli@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50433
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#135: FILE: test/test/test_rcu_qsbr.c:18:
+#define RCU_QSBR_RETURN_IF_ERROR(cond, str, ...) do { \
+ if (cond) { \
+ printf("ERROR file %s, line %d: " str "
", __FILE__, \
+ __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#992: FILE: test/test/test_rcu_qsbr_perf.c:38:
+extern int test_rcu_qsbr_get_memsize(void);
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1060: FILE: test/test/test_rcu_qsbr_perf.c:106:
+ if (wait) rte_rcu_qsbr_start(&t, 1, &token);
total: 1 errors, 2 warnings, 1160 lines checked
parent reply other threads:[~2019-02-22 7:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190222070427.22866-3-honnappa.nagarahalli@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222070651.2EFFF2BF4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).