From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2EFFF2BF4; Fri, 22 Feb 2019 08:06:51 +0100 (CET)
In-Reply-To: <20190222070427.22866-3-honnappa.nagarahalli@arm.com>
References: <20190222070427.22866-3-honnappa.nagarahalli@arm.com>
To: test-report@dpdk.org
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Message-Id: <20190222070651.2EFFF2BF4@dpdk.org>
Date: Fri, 22 Feb 2019 08:06:51 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw50433 [RFC, v3,
	2/5] test/rcu_qsbr: add API and functional tests
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 07:06:51 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50433

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#135: FILE: test/test/test_rcu_qsbr.c:18:
+#define RCU_QSBR_RETURN_IF_ERROR(cond, str, ...) do { \
+	if (cond) { \
+		printf("ERROR file %s, line %d: " str "
", __FILE__, \
+			__LINE__, ##__VA_ARGS__); \
+		return -1; \
+	} \
+} while (0)

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#992: FILE: test/test/test_rcu_qsbr_perf.c:38:
+extern int test_rcu_qsbr_get_memsize(void);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1060: FILE: test/test/test_rcu_qsbr_perf.c:106:
+		if (wait) rte_rcu_qsbr_start(&t, 1, &token);

total: 1 errors, 2 warnings, 1160 lines checked