From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id E8B752C08; Fri, 22 Feb 2019 10:55:38 +0100 (CET) In-Reply-To: <20190222150336.22299-1-leyi.rong@intel.com> References: <20190222150336.22299-1-leyi.rong@intel.com> To: test-report@dpdk.org Cc: Leyi Rong Message-Id: <20190222095538.E8B752C08@dpdk.org> Date: Fri, 22 Feb 2019 10:55:38 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw50439 [1/2] net/iavf: rename avf to iavf X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 09:55:39 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/50439 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around hw->aq.asq #8837: FILE: drivers/net/iavf/base/iavf_adminq.c:626: + struct iavf_adminq_ring *asq = &(hw->aq.asq); WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else #9471: FILE: drivers/net/iavf/base/iavf_adminq.h:141: + -ENOSYS, /* IAVF_AQ_RC_ENOSYS */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #9507: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:2: +/******************************************************************************* + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #9846: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:341: +#define IAVF_CHECK_STRUCT_LEN(n, X) enum iavf_static_assert_enum_##X \ + { iavf_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #9847: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:342: + { iavf_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ WARNING:TYPO_SPELLING: 'capabilites' may be misspelled - perhaps 'capabilities'? #9921: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:416: +struct iavf_aqc_list_capabilites { WARNING:TYPO_SPELLING: 'capabilites' may be misspelled - perhaps 'capabilities'? #9931: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:426: +IAVF_CHECK_CMD_LENGTH(iavf_aqc_list_capabilites); WARNING:TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? #11710: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:2205: + u8 dev_addres; WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #12420: FILE: drivers/net/iavf/base/iavf_common.c:2: +/******************************************************************************* + WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'iavf_set_mac_type', this function's name, in a string #12469: FILE: drivers/net/iavf/base/iavf_common.c:51: + DEBUGFUNC("iavf_set_mac_type "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'iavf_set_mac_type', this function's name, in a string #12487: FILE: drivers/net/iavf/base/iavf_common.c:69: + DEBUGOUT2("iavf_set_mac_type found mac: %d, returns: %d ", CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'desc == NULL' #12718: FILE: drivers/net/iavf/base/iavf_common.c:300: + if ((!(mask & hw->debug_mask)) || (desc == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'buffer != NULL' #12739: FILE: drivers/net/iavf/base/iavf_common.c:321: + if ((buffer != NULL) && (aq_desc->datalen != 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'aq_desc->datalen != 0' #12739: FILE: drivers/net/iavf/base/iavf_common.c:321: + if ((buffer != NULL) && (aq_desc->datalen != 0)) { CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12747: FILE: drivers/net/iavf/base/iavf_common.c:329: + i, buf[i], buf[i+1], buf[i+2], buf[i+3], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12747: FILE: drivers/net/iavf/base/iavf_common.c:329: + i, buf[i], buf[i+1], buf[i+2], buf[i+3], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12747: FILE: drivers/net/iavf/base/iavf_common.c:329: + i, buf[i], buf[i+1], buf[i+2], buf[i+3], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12748: FILE: drivers/net/iavf/base/iavf_common.c:330: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12748: FILE: drivers/net/iavf/base/iavf_common.c:330: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12748: FILE: drivers/net/iavf/base/iavf_common.c:330: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12748: FILE: drivers/net/iavf/base/iavf_common.c:330: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12749: FILE: drivers/net/iavf/base/iavf_common.c:331: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12749: FILE: drivers/net/iavf/base/iavf_common.c:331: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12749: FILE: drivers/net/iavf/base/iavf_common.c:331: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12749: FILE: drivers/net/iavf/base/iavf_common.c:331: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12750: FILE: drivers/net/iavf/base/iavf_common.c:332: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12750: FILE: drivers/net/iavf/base/iavf_common.c:332: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12750: FILE: drivers/net/iavf/base/iavf_common.c:332: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #12750: FILE: drivers/net/iavf/base/iavf_common.c:332: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ WARNING:TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? #13515: FILE: drivers/net/iavf/base/iavf_common.c:1097: + cmd->dev_addres = dev_addr; WARNING:TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? #13549: FILE: drivers/net/iavf/base/iavf_common.c:1131: + cmd->dev_addres = dev_addr; WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #13825: FILE: drivers/net/iavf/base/iavf_common.c:1407: +/** +* iavf_aq_clear_all_wol_filters CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == dev_cnt' #14079: FILE: drivers/net/iavf/base/iavf_common.c:1661: + if (dev_cnt && (i == dev_cnt)) { WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #14297: FILE: drivers/net/iavf/base/iavf_hmc.h:2: +/******************************************************************************* + CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #14367: FILE: drivers/net/iavf/base/iavf_hmc.h:72: + bool rsrc_pg; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #14368: FILE: drivers/net/iavf/base/iavf_hmc.h:73: + bool valid; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #14382: FILE: drivers/net/iavf/base/iavf_hmc.h:87: + bool valid; CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #14424: FILE: drivers/net/iavf/base/iavf_hmc.h:129: +#define IAVF_SET_PF_SD_ENTRY(hw, pa, sd_index, type) \ +{ \ + u32 val1, val2, val3; \ + val1 = (u32)(IAVF_HI_DWORD(pa)); \ + val2 = (u32)(pa) | (IAVF_HMC_MAX_BP_COUNT << \ + IAVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == IAVF_SD_TYPE_PAGED) ? 0 : 1) << \ + IAVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT) | \ + BIT(IAVF_PFHMC_SDDATALOW_PMSDVALID_SHIFT); \ + val3 = (sd_index) | BIT_ULL(IAVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), IAVF_PFHMC_SDDATAHIGH, val1); \ + wr32((hw), IAVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), IAVF_PFHMC_SDCMD, val3); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pa' - possible side-effects? #14424: FILE: drivers/net/iavf/base/iavf_hmc.h:129: +#define IAVF_SET_PF_SD_ENTRY(hw, pa, sd_index, type) \ +{ \ + u32 val1, val2, val3; \ + val1 = (u32)(IAVF_HI_DWORD(pa)); \ + val2 = (u32)(pa) | (IAVF_HMC_MAX_BP_COUNT << \ + IAVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == IAVF_SD_TYPE_PAGED) ? 0 : 1) << \ + IAVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT) | \ + BIT(IAVF_PFHMC_SDDATALOW_PMSDVALID_SHIFT); \ + val3 = (sd_index) | BIT_ULL(IAVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), IAVF_PFHMC_SDDATAHIGH, val1); \ + wr32((hw), IAVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), IAVF_PFHMC_SDCMD, val3); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #14445: FILE: drivers/net/iavf/base/iavf_hmc.h:150: +#define IAVF_CLEAR_PF_SD_ENTRY(hw, sd_index, type) \ +{ \ + u32 val2, val3; \ + val2 = (IAVF_HMC_MAX_BP_COUNT << \ + IAVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == IAVF_SD_TYPE_PAGED) ? 0 : 1) << \ + IAVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT); \ + val3 = (sd_index) | BIT_ULL(IAVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), IAVF_PFHMC_SDDATAHIGH, 0); \ + wr32((hw), IAVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), IAVF_PFHMC_SDCMD, val3); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmc_info' - possible side-effects? #14481: FILE: drivers/net/iavf/base/iavf_hmc.h:186: +#define IAVF_FIND_SD_INDEX_LIMIT(hmc_info, type, index, cnt, sd_idx, sd_limit)\ +{ \ + u64 fpm_addr, fpm_limit; \ + fpm_addr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (index); \ + fpm_limit = fpm_addr + (hmc_info)->hmc_obj[(type)].size * (cnt);\ + *(sd_idx) = (u32)(fpm_addr / IAVF_HMC_DIRECT_BP_SIZE); \ + *(sd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_DIRECT_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(sd_limit) += 1; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sd_limit' - possible side-effects? #14481: FILE: drivers/net/iavf/base/iavf_hmc.h:186: +#define IAVF_FIND_SD_INDEX_LIMIT(hmc_info, type, index, cnt, sd_idx, sd_limit)\ +{ \ + u64 fpm_addr, fpm_limit; \ + fpm_addr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (index); \ + fpm_limit = fpm_addr + (hmc_info)->hmc_obj[(type)].size * (cnt);\ + *(sd_idx) = (u32)(fpm_addr / IAVF_HMC_DIRECT_BP_SIZE); \ + *(sd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_DIRECT_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(sd_limit) += 1; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmc_info' - possible side-effects? #14505: FILE: drivers/net/iavf/base/iavf_hmc.h:210: +#define IAVF_FIND_PD_INDEX_LIMIT(hmc_info, type, idx, cnt, pd_index, pd_limit)\ +{ \ + u64 fpm_adr, fpm_limit; \ + fpm_adr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (idx); \ + fpm_limit = fpm_adr + (hmc_info)->hmc_obj[(type)].size * (cnt); \ + *(pd_index) = (u32)(fpm_adr / IAVF_HMC_PAGED_BP_SIZE); \ + *(pd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_PAGED_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(pd_limit) += 1; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd_limit' - possible side-effects? #14505: FILE: drivers/net/iavf/base/iavf_hmc.h:210: +#define IAVF_FIND_PD_INDEX_LIMIT(hmc_info, type, idx, cnt, pd_index, pd_limit)\ +{ \ + u64 fpm_adr, fpm_limit; \ + fpm_adr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (idx); \ + fpm_limit = fpm_adr + (hmc_info)->hmc_obj[(type)].size * (cnt); \ + *(pd_index) = (u32)(fpm_adr / IAVF_HMC_PAGED_BP_SIZE); \ + *(pd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_PAGED_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(pd_limit) += 1; \ +} ERROR:SPACING: space required before the open parenthesis '(' #14782: FILE: drivers/net/iavf/base/iavf_osdep.h:73: +#define ASSERT(x) if(!(x)) rte_panic("IAVF: x") ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #14782: FILE: drivers/net/iavf/base/iavf_osdep.h:73: +#define ASSERT(x) if(!(x)) rte_panic("IAVF: x") CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects? #14842: FILE: drivers/net/iavf/base/iavf_osdep.h:126: +#define iavf_debug(h, m, s, ...) \ do { \ if (((m) & (h)->debug_mask)) \ + PMD_DRV_LOG_RAW(DEBUG, "iavf %02x.%x " s, \ (h)->bus.device, (h)->bus.func, \ ##__VA_ARGS__); \ } while (0) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #14929: FILE: drivers/net/iavf/base/iavf_prototype.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #15141: FILE: drivers/net/iavf/base/iavf_register.h:2: +/******************************************************************************* + WARNING:LONG_LINE_COMMENT: line over 90 characters #15177: FILE: drivers/net/iavf/base/iavf_register.h:38: +#define IAVFMSIX_PBA1(_i) (0x00002000 + ((_i) * 4)) /* _i=0...19 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15181: FILE: drivers/net/iavf/base/iavf_register.h:42: +#define IAVFMSIX_TADD1(_i) (0x00002100 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #15186: FILE: drivers/net/iavf/base/iavf_register.h:47: +#define IAVFMSIX_TADD1_MSIXTADD_MASK IAVF_MASK(0x3FFFFFFF, IAVFMSIX_TADD1_MSIXTADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15187: FILE: drivers/net/iavf/base/iavf_register.h:48: +#define IAVFMSIX_TMSG1(_i) (0x00002108 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15191: FILE: drivers/net/iavf/base/iavf_register.h:52: +#define IAVFMSIX_TUADD1(_i) (0x00002104 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #15194: FILE: drivers/net/iavf/base/iavf_register.h:55: +#define IAVFMSIX_TUADD1_MSIXTUADD_MASK IAVF_MASK(0xFFFFFFFF, IAVFMSIX_TUADD1_MSIXTUADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15195: FILE: drivers/net/iavf/base/iavf_register.h:56: +#define IAVFMSIX_TVCTRL1(_i) (0x0000210C + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #15250: FILE: drivers/net/iavf/base/iavf_register.h:111: +#define IAVFINT_DYN_CTL01_INTENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_INTENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #15252: FILE: drivers/net/iavf/base/iavf_register.h:113: +#define IAVFINT_DYN_CTL01_CLEARPBA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_CLEARPBA_SHIFT) WARNING:LONG_LINE: line over 90 characters #15254: FILE: drivers/net/iavf/base/iavf_register.h:115: +#define IAVFINT_DYN_CTL01_SWINT_TRIG_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_SWINT_TRIG_SHIFT) WARNING:LONG_LINE: line over 90 characters #15256: FILE: drivers/net/iavf/base/iavf_register.h:117: +#define IAVFINT_DYN_CTL01_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTL01_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #15258: FILE: drivers/net/iavf/base/iavf_register.h:119: +#define IAVFINT_DYN_CTL01_INTERVAL_MASK IAVF_MASK(0xFFF, IAVFINT_DYN_CTL01_INTERVAL_SHIFT) WARNING:LONG_LINE: line over 90 characters #15260: FILE: drivers/net/iavf/base/iavf_register.h:121: +#define IAVFINT_DYN_CTL01_SW_ITR_INDX_ENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_SW_ITR_INDX_ENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #15262: FILE: drivers/net/iavf/base/iavf_register.h:123: +#define IAVFINT_DYN_CTL01_SW_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTL01_SW_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #15264: FILE: drivers/net/iavf/base/iavf_register.h:125: +#define IAVFINT_DYN_CTL01_INTENA_MSK_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_INTENA_MSK_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15265: FILE: drivers/net/iavf/base/iavf_register.h:126: +#define IAVFINT_DYN_CTLN1(_INTVF) (0x00003800 + ((_INTVF) * 4)) /* _i=0...15 */ /* Reset: VFR */ WARNING:LONG_LINE: line over 90 characters #15268: FILE: drivers/net/iavf/base/iavf_register.h:129: +#define IAVFINT_DYN_CTLN1_INTENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_INTENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #15270: FILE: drivers/net/iavf/base/iavf_register.h:131: +#define IAVFINT_DYN_CTLN1_CLEARPBA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_CLEARPBA_SHIFT) WARNING:LONG_LINE: line over 90 characters #15272: FILE: drivers/net/iavf/base/iavf_register.h:133: +#define IAVFINT_DYN_CTLN1_SWINT_TRIG_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_SWINT_TRIG_SHIFT) WARNING:LONG_LINE: line over 90 characters #15274: FILE: drivers/net/iavf/base/iavf_register.h:135: +#define IAVFINT_DYN_CTLN1_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTLN1_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #15276: FILE: drivers/net/iavf/base/iavf_register.h:137: +#define IAVFINT_DYN_CTLN1_INTERVAL_MASK IAVF_MASK(0xFFF, IAVFINT_DYN_CTLN1_INTERVAL_SHIFT) WARNING:LONG_LINE: line over 90 characters #15278: FILE: drivers/net/iavf/base/iavf_register.h:139: +#define IAVFINT_DYN_CTLN1_SW_ITR_INDX_ENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_SW_ITR_INDX_ENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #15280: FILE: drivers/net/iavf/base/iavf_register.h:141: +#define IAVFINT_DYN_CTLN1_SW_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTLN1_SW_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #15282: FILE: drivers/net/iavf/base/iavf_register.h:143: +#define IAVFINT_DYN_CTLN1_INTENA_MSK_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_INTENA_MSK_SHIFT) WARNING:LONG_LINE: line over 90 characters #15285: FILE: drivers/net/iavf/base/iavf_register.h:146: +#define IAVFINT_ICR0_ENA1_LINK_STAT_CHANGE_MASK IAVF_MASK(0x1, IAVFINT_ICR0_ENA1_LINK_STAT_CHANGE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15287: FILE: drivers/net/iavf/base/iavf_register.h:148: +#define IAVFINT_ICR0_ENA1_ADMINQ_MASK IAVF_MASK(0x1, IAVFINT_ICR0_ENA1_ADMINQ_SHIFT) WARNING:LONG_LINE: line over 90 characters #15289: FILE: drivers/net/iavf/base/iavf_register.h:150: +#define IAVFINT_ICR0_ENA1_RSVD_MASK IAVF_MASK(0x1, IAVFINT_ICR0_ENA1_RSVD_SHIFT) WARNING:LONG_LINE: line over 90 characters #15302: FILE: drivers/net/iavf/base/iavf_register.h:163: +#define IAVFINT_ICR01_LINK_STAT_CHANGE_MASK IAVF_MASK(0x1, IAVFINT_ICR01_LINK_STAT_CHANGE_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15307: FILE: drivers/net/iavf/base/iavf_register.h:168: +#define IAVFINT_ITR01(_i) (0x00004C00 + ((_i) * 4)) /* _i=0...2 */ /* Reset: VFR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15311: FILE: drivers/net/iavf/base/iavf_register.h:172: +#define IAVFINT_ITRN1(_i, _INTVF) (0x00002800 + ((_i) * 64 + (_INTVF) * 4)) /* _i=0...2, _INTVF=0...15 */ /* Reset: VFR */ WARNING:LONG_LINE: line over 90 characters #15317: FILE: drivers/net/iavf/base/iavf_register.h:178: +#define IAVFINT_STAT_CTL01_OTHER_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_STAT_CTL01_OTHER_ITR_INDX_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15318: FILE: drivers/net/iavf/base/iavf_register.h:179: +#define IAVF_QRX_TAIL1(_Q) (0x00002000 + ((_Q) * 4)) /* _i=0...15 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15322: FILE: drivers/net/iavf/base/iavf_register.h:183: +#define IAVF_QTX_TAIL1(_Q) (0x00000000 + ((_Q) * 4)) /* _i=0...15 */ /* Reset: PFR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15329: FILE: drivers/net/iavf/base/iavf_register.h:190: +#define IAVFMSIX_TADD(_i) (0x00000000 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15335: FILE: drivers/net/iavf/base/iavf_register.h:196: +#define IAVFMSIX_TMSG(_i) (0x00000008 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15339: FILE: drivers/net/iavf/base/iavf_register.h:200: +#define IAVFMSIX_TUADD(_i) (0x00000004 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #15342: FILE: drivers/net/iavf/base/iavf_register.h:203: +#define IAVFMSIX_TUADD_MSIXTUADD_MASK IAVF_MASK(0xFFFFFFFF, IAVFMSIX_TUADD_MSIXTUADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15343: FILE: drivers/net/iavf/base/iavf_register.h:204: +#define IAVFMSIX_TVCTRL(_i) (0x0000000C + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #15349: FILE: drivers/net/iavf/base/iavf_register.h:210: +#define IAVFCM_PE_ERRDATA_ERROR_CODE_MASK IAVF_MASK(0xF, IAVFCM_PE_ERRDATA_ERROR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15353: FILE: drivers/net/iavf/base/iavf_register.h:214: +#define IAVFCM_PE_ERRDATA_Q_NUM_MASK IAVF_MASK(0x3FFFF, IAVFCM_PE_ERRDATA_Q_NUM_SHIFT) WARNING:LONG_LINE: line over 90 characters #15356: FILE: drivers/net/iavf/base/iavf_register.h:217: +#define IAVFCM_PE_ERRINFO_ERROR_VALID_MASK IAVF_MASK(0x1, IAVFCM_PE_ERRINFO_ERROR_VALID_SHIFT) WARNING:LONG_LINE: line over 90 characters #15358: FILE: drivers/net/iavf/base/iavf_register.h:219: +#define IAVFCM_PE_ERRINFO_ERROR_INST_MASK IAVF_MASK(0x7, IAVFCM_PE_ERRINFO_ERROR_INST_SHIFT) WARNING:LONG_LINE: line over 90 characters #15360: FILE: drivers/net/iavf/base/iavf_register.h:221: +#define IAVFCM_PE_ERRINFO_DBL_ERROR_CNT_MASK IAVF_MASK(0xFF, IAVFCM_PE_ERRINFO_DBL_ERROR_CNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #15362: FILE: drivers/net/iavf/base/iavf_register.h:223: +#define IAVFCM_PE_ERRINFO_RLU_ERROR_CNT_MASK IAVF_MASK(0xFF, IAVFCM_PE_ERRINFO_RLU_ERROR_CNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #15364: FILE: drivers/net/iavf/base/iavf_register.h:225: +#define IAVFCM_PE_ERRINFO_RLS_ERROR_CNT_MASK IAVF_MASK(0xFF, IAVFCM_PE_ERRINFO_RLS_ERROR_CNT_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #15365: FILE: drivers/net/iavf/base/iavf_register.h:226: +#define IAVFQF_HENA(_i) (0x0000C400 + ((_i) * 4)) /* _i=0...1 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15369: FILE: drivers/net/iavf/base/iavf_register.h:230: +#define IAVFQF_HKEY(_i) (0x0000CC00 + ((_i) * 4)) /* _i=0...12 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15379: FILE: drivers/net/iavf/base/iavf_register.h:240: +#define IAVFQF_HLUT(_i) (0x0000D000 + ((_i) * 4)) /* _i=0...15 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #15389: FILE: drivers/net/iavf/base/iavf_register.h:250: +#define IAVFQF_HREGION(_i) (0x0000D400 + ((_i) * 4)) /* _i=0...7 */ /* Reset: CORER */ WARNING:LONG_LINE: line over 90 characters #15392: FILE: drivers/net/iavf/base/iavf_register.h:253: +#define IAVFQF_HREGION_OVERRIDE_ENA_0_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_0_SHIFT) WARNING:LONG_LINE: line over 90 characters #15396: FILE: drivers/net/iavf/base/iavf_register.h:257: +#define IAVFQF_HREGION_OVERRIDE_ENA_1_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_1_SHIFT) WARNING:LONG_LINE: line over 90 characters #15400: FILE: drivers/net/iavf/base/iavf_register.h:261: +#define IAVFQF_HREGION_OVERRIDE_ENA_2_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_2_SHIFT) WARNING:LONG_LINE: line over 90 characters #15404: FILE: drivers/net/iavf/base/iavf_register.h:265: +#define IAVFQF_HREGION_OVERRIDE_ENA_3_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_3_SHIFT) WARNING:LONG_LINE: line over 90 characters #15408: FILE: drivers/net/iavf/base/iavf_register.h:269: +#define IAVFQF_HREGION_OVERRIDE_ENA_4_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_4_SHIFT) WARNING:LONG_LINE: line over 90 characters #15412: FILE: drivers/net/iavf/base/iavf_register.h:273: +#define IAVFQF_HREGION_OVERRIDE_ENA_5_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_5_SHIFT) WARNING:LONG_LINE: line over 90 characters #15416: FILE: drivers/net/iavf/base/iavf_register.h:277: +#define IAVFQF_HREGION_OVERRIDE_ENA_6_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_6_SHIFT) WARNING:LONG_LINE: line over 90 characters #15420: FILE: drivers/net/iavf/base/iavf_register.h:281: +#define IAVFQF_HREGION_OVERRIDE_ENA_7_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_7_SHIFT) WARNING:LONG_LINE: line over 90 characters #15425: FILE: drivers/net/iavf/base/iavf_register.h:286: +#define IAVFINT_DYN_CTL01_WB_ON_ITR_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_WB_ON_ITR_SHIFT) WARNING:LONG_LINE: line over 90 characters #15427: FILE: drivers/net/iavf/base/iavf_register.h:288: +#define IAVFINT_DYN_CTLN1_WB_ON_ITR_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_WB_ON_ITR_SHIFT) WARNING:LONG_LINE: line over 90 characters #15430: FILE: drivers/net/iavf/base/iavf_register.h:291: +#define IAVFPE_AEQALLOC1_AECOUNT_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_AEQALLOC1_AECOUNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #15433: FILE: drivers/net/iavf/base/iavf_register.h:294: +#define IAVFPE_CCQPHIGH1_PECCQPHIGH_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_CCQPHIGH1_PECCQPHIGH_SHIFT) WARNING:LONG_LINE: line over 90 characters #15436: FILE: drivers/net/iavf/base/iavf_register.h:297: +#define IAVFPE_CCQPLOW1_PECCQPLOW_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_CCQPLOW1_PECCQPLOW_SHIFT) WARNING:LONG_LINE: line over 90 characters #15439: FILE: drivers/net/iavf/base/iavf_register.h:300: +#define IAVFPE_CCQPSTATUS1_CCQP_DONE_MASK IAVF_MASK(0x1, IAVFPE_CCQPSTATUS1_CCQP_DONE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15441: FILE: drivers/net/iavf/base/iavf_register.h:302: +#define IAVFPE_CCQPSTATUS1_HMC_PROFILE_MASK IAVF_MASK(0x7, IAVFPE_CCQPSTATUS1_HMC_PROFILE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15443: FILE: drivers/net/iavf/base/iavf_register.h:304: +#define IAVFPE_CCQPSTATUS1_RDMA_EN_VFS_MASK IAVF_MASK(0x3F, IAVFPE_CCQPSTATUS1_RDMA_EN_VFS_SHIFT) WARNING:LONG_LINE: line over 90 characters #15445: FILE: drivers/net/iavf/base/iavf_register.h:306: +#define IAVFPE_CCQPSTATUS1_CCQP_ERR_MASK IAVF_MASK(0x1, IAVFPE_CCQPSTATUS1_CCQP_ERR_SHIFT) WARNING:LONG_LINE: line over 90 characters #15457: FILE: drivers/net/iavf/base/iavf_register.h:318: +#define IAVFPE_CQPERRCODES1_CQP_MINOR_CODE_MASK IAVF_MASK(0xFFFF, IAVFPE_CQPERRCODES1_CQP_MINOR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15459: FILE: drivers/net/iavf/base/iavf_register.h:320: +#define IAVFPE_CQPERRCODES1_CQP_MAJOR_CODE_MASK IAVF_MASK(0xFFFF, IAVFPE_CQPERRCODES1_CQP_MAJOR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15467: FILE: drivers/net/iavf/base/iavf_register.h:328: +#define IAVFPE_IPCONFIG01_PEIPID_MASK IAVF_MASK(0xFFFF, IAVFPE_IPCONFIG01_PEIPID_SHIFT) WARNING:LONG_LINE: line over 90 characters #15469: FILE: drivers/net/iavf/base/iavf_register.h:330: +#define IAVFPE_IPCONFIG01_USEENTIREIDRANGE_MASK IAVF_MASK(0x1, IAVFPE_IPCONFIG01_USEENTIREIDRANGE_SHIFT) WARNING:LONG_LINE: line over 90 characters #15472: FILE: drivers/net/iavf/base/iavf_register.h:333: +#define IAVFPE_MRTEIDXMASK1_MRTEIDXMASKBITS_MASK IAVF_MASK(0x1F, IAVFPE_MRTEIDXMASK1_MRTEIDXMASKBITS_SHIFT) WARNING:LONG_LINE: line over 90 characters #15475: FILE: drivers/net/iavf/base/iavf_register.h:336: +#define IAVFPE_RCVUNEXPECTEDERROR1_TCP_RX_UNEXP_ERR_MASK IAVF_MASK(0xFFFFFF, IAVFPE_RCVUNEXPECTEDERROR1_TCP_RX_UNEXP_ERR_SHIFT) WARNING:LONG_LINE: line over 90 characters #15478: FILE: drivers/net/iavf/base/iavf_register.h:339: +#define IAVFPE_TCPNOWTIMER1_TCP_NOW_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_TCPNOWTIMER1_TCP_NOW_SHIFT) WARNING:LONG_LINE: line over 90 characters #15481: FILE: drivers/net/iavf/base/iavf_register.h:342: +#define IAVFPE_WQEALLOC1_PEQPID_MASK IAVF_MASK(0x3FFFF, IAVFPE_WQEALLOC1_PEQPID_SHIFT) WARNING:LONG_LINE: line over 90 characters #15483: FILE: drivers/net/iavf/base/iavf_register.h:344: +#define IAVFPE_WQEALLOC1_WQE_DESC_INDEX_MASK IAVF_MASK(0xFFF, IAVFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #15493: FILE: drivers/net/iavf/base/iavf_status.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #15607: FILE: drivers/net/iavf/base/iavf_type.h:2: +/******************************************************************************* + WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #15651: FILE: drivers/net/iavf/base/iavf_type.h:46: +#define UNREFERENCED_1PARAMETER(_p) (_p); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #15652: FILE: drivers/net/iavf/base/iavf_type.h:47: +#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #15652: FILE: drivers/net/iavf/base/iavf_type.h:47: +#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #15653: FILE: drivers/net/iavf/base/iavf_type.h:48: +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #15653: FILE: drivers/net/iavf/base/iavf_type.h:48: +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #15654: FILE: drivers/net/iavf/base/iavf_type.h:49: +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #15654: FILE: drivers/net/iavf/base/iavf_type.h:49: +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #15655: FILE: drivers/net/iavf/base/iavf_type.h:50: +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #15655: FILE: drivers/net/iavf/base/iavf_type.h:50: +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mask' may be better as '(mask)' to avoid precedence issues #15668: FILE: drivers/net/iavf/base/iavf_type.h:63: +#define IAVF_MASK(mask, shift) (mask << shift) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'shift' may be better as '(shift)' to avoid precedence issues #15668: FILE: drivers/net/iavf/base/iavf_type.h:63: +#define IAVF_MASK(mask, shift) (mask << shift) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'address' - possible side-effects? #15692: FILE: drivers/net/iavf/base/iavf_type.h:87: +#define IAVF_IS_BROADCAST(address) \ + ((((u8 *)(address))[0] == ((u8)0xff)) && \ + (((u8 *)(address))[1] == ((u8)0xff))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'R' - possible side-effects? #15723: FILE: drivers/net/iavf/base/iavf_type.h:118: +#define IAVF_DESC_UNUSED(R) \ + ((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->count) + \ + (R)->next_to_clean - (R)->next_to_use - 1) CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15883: FILE: drivers/net/iavf/base/iavf_type.h:278: + bool lse_enable; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15885: FILE: drivers/net/iavf/base/iavf_type.h:280: + bool crc_enable; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15911: FILE: drivers/net/iavf/base/iavf_type.h:306: + bool get_link_info; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15994: FILE: drivers/net/iavf/base/iavf_type.h:389: + bool sr_iov_1_1; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15995: FILE: drivers/net/iavf/base/iavf_type.h:390: + bool vmdq; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15996: FILE: drivers/net/iavf/base/iavf_type.h:391: + bool evb_802_1_qbg; /* Edge Virtual Bridging */ CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15997: FILE: drivers/net/iavf/base/iavf_type.h:392: + bool evb_802_1_qbh; /* Bridge Port Extension */ CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15998: FILE: drivers/net/iavf/base/iavf_type.h:393: + bool dcb; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #15999: FILE: drivers/net/iavf/base/iavf_type.h:394: + bool fcoe; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16000: FILE: drivers/net/iavf/base/iavf_type.h:395: + bool iscsi; /* Indicates iSCSI enabled */ CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16001: FILE: drivers/net/iavf/base/iavf_type.h:396: + bool flex10_enable; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16002: FILE: drivers/net/iavf/base/iavf_type.h:397: + bool flex10_capable; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16012: FILE: drivers/net/iavf/base/iavf_type.h:407: + bool sec_rev_disabled; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16013: FILE: drivers/net/iavf/base/iavf_type.h:408: + bool update_disabled; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16017: FILE: drivers/net/iavf/base/iavf_type.h:412: + bool mgmt_cem; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16018: FILE: drivers/net/iavf/base/iavf_type.h:413: + bool ieee_1588; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16019: FILE: drivers/net/iavf/base/iavf_type.h:414: + bool iwarp; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16020: FILE: drivers/net/iavf/base/iavf_type.h:415: + bool fd; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16023: FILE: drivers/net/iavf/base/iavf_type.h:418: + bool rss; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16046: FILE: drivers/net/iavf/base/iavf_type.h:441: + bool apm_wol_support; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16048: FILE: drivers/net/iavf/base/iavf_type.h:443: + bool proxy_support; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16073: FILE: drivers/net/iavf/base/iavf_type.h:468: + bool blank_nvm_mode; /* is NVM empty (no FW present)*/ CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16288: FILE: drivers/net/iavf/base/iavf_type.h:683: + bool adapter_stopped; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #16317: FILE: drivers/net/iavf/base/iavf_type.h:712: + bool nvm_release_on_done; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17444: FILE: drivers/net/iavf/base/iavf_type.h:1839: + bool enable_fdir; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17446: FILE: drivers/net/iavf/base/iavf_type.h:1841: + bool enable_ethtype; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17448: FILE: drivers/net/iavf/base/iavf_type.h:1843: + bool enable_macvlan; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17789: FILE: drivers/net/iavf/iavf.h:84: + bool promisc_unicast_enabled; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17790: FILE: drivers/net/iavf/iavf.h:85: + bool promisc_multicast_enabled; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17801: FILE: drivers/net/iavf/iavf.h:96: + bool dev_closed; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17802: FILE: drivers/net/iavf/iavf.h:97: + bool link_up; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17806: FILE: drivers/net/iavf/iavf.h:101: + bool vf_reset; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17825: FILE: drivers/net/iavf/iavf.h:120: + bool rx_bulk_alloc_allowed; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17827: FILE: drivers/net/iavf/iavf.h:122: + bool rx_vec_allowed; CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #17828: FILE: drivers/net/iavf/iavf.h:123: + bool tx_vec_allowed; CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #18299: FILE: drivers/net/iavf/iavf_ethdev.c:326: + interval = iavf_calc_itr_interval( CHECK:CAMELCASE: Avoid CamelCase: #19334: FILE: drivers/net/iavf/iavf_ethdev.c:1365: + snprintf(z_name, sizeof(z_name), "iavf_dma_%"PRIu64, rte_rand()); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #19334: FILE: drivers/net/iavf/iavf_ethdev.c:1365: + snprintf(z_name, sizeof(z_name), "iavf_dma_%"PRIu64, rte_rand()); ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #21081: FILE: drivers/net/iavf/iavf_rxtx.h:25: +#define IAVF_NO_VECTOR_FLAGS ( \ DEV_TX_OFFLOAD_MULTI_SEGS | \ DEV_TX_OFFLOAD_VLAN_INSERT | \ DEV_TX_OFFLOAD_SCTP_CKSUM | \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #21105: FILE: drivers/net/iavf/iavf_rxtx.h:45: +#define IAVF_TX_OFFLOAD_MASK ( \ PKT_TX_OUTER_IPV6 | \ PKT_TX_OUTER_IPV4 | \ PKT_TX_IPV6 | \ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #21313: FILE: drivers/net/iavf/iavf_rxtx.h:238: + type = (enum iavf_tx_desc_dtype_value)rte_le_to_cpu_64( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #21915: FILE: drivers/net/iavf/iavf_vchnl.c:204: + msg_ret = (enum iavf_status_code)rte_le_to_cpu_32( total: 8 errors, 96 warnings, 14043 lines checked