automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: wanjunjie <wan.junjie@foxmail.com>
Subject: [dpdk-test-report] |WARNING| pw50454 [v4] lib/metrics: add unregister api for metrics
Date: Fri, 22 Feb 2019 16:39:40 +0100 (CET)	[thread overview]
Message-ID: <20190222153940.17FF52C57@dpdk.org> (raw)
In-Reply-To: <1550849955-15101-1-git-send-email-wan.junjie@foxmail.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50454

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#135: FILE: lib/librte_metrics/rte_metrics.c:136:
+			if (idx == idx_base + cnt_names) {
+				break;
+			}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#141: FILE: lib/librte_metrics/rte_metrics.c:142:
+	if (idx_base == RTE_METRICS_MAX_METRICS) {
+		return -ENOMEM;
+	}

ERROR:SPACING: space prohibited before that close parenthesis ')'
#208: FILE: lib/librte_metrics/rte_metrics.c:233:
+	if (count < 1 )

ERROR:TRAILING_WHITESPACE: trailing whitespace
#271: FILE: lib/librte_metrics/rte_metrics.c:298:
+^I^Ifor (idx_name = 0; idx < stats->cnt_stats && $

total: 2 errors, 2 warnings, 310 lines checked

           reply	other threads:[~2019-02-22 15:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1550849955-15101-1-git-send-email-wan.junjie@foxmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222153940.17FF52C57@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=wan.junjie@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).