From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 17FF52C57; Fri, 22 Feb 2019 16:39:40 +0100 (CET)
In-Reply-To: <1550849955-15101-1-git-send-email-wan.junjie@foxmail.com>
References: <1550849955-15101-1-git-send-email-wan.junjie@foxmail.com>
To: test-report@dpdk.org
Cc: wanjunjie <wan.junjie@foxmail.com>
Message-Id: <20190222153940.17FF52C57@dpdk.org>
Date: Fri, 22 Feb 2019 16:39:40 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw50454 [v4] lib/metrics: add
	unregister api for metrics
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 15:39:40 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50454

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#135: FILE: lib/librte_metrics/rte_metrics.c:136:
+			if (idx == idx_base + cnt_names) {
+				break;
+			}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#141: FILE: lib/librte_metrics/rte_metrics.c:142:
+	if (idx_base == RTE_METRICS_MAX_METRICS) {
+		return -ENOMEM;
+	}

ERROR:SPACING: space prohibited before that close parenthesis ')'
#208: FILE: lib/librte_metrics/rte_metrics.c:233:
+	if (count < 1 )

ERROR:TRAILING_WHITESPACE: trailing whitespace
#271: FILE: lib/librte_metrics/rte_metrics.c:298:
+^I^Ifor (idx_name = 0; idx < stats->cnt_stats && $

total: 2 errors, 2 warnings, 310 lines checked