From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 83DC33421; Mon, 25 Feb 2019 12:23:34 +0100 (CET) In-Reply-To: <20190225171853.4643-3-leyi.rong@intel.com> References: <20190225171853.4643-3-leyi.rong@intel.com> To: test-report@dpdk.org Cc: Leyi Rong Message-Id: <20190225112334.83DC33421@dpdk.org> Date: Mon, 25 Feb 2019 12:23:34 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw50487 [v2, 2/3] net/iavf: rename remaining avf strings X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 11:23:34 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/50487 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around hw->aq.asq #870: FILE: drivers/net/iavf/base/iavf_adminq.c:626: + struct iavf_adminq_ring *asq = &(hw->aq.asq); WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else #1498: FILE: drivers/net/iavf/base/iavf_adminq.h:141: + -ENOSYS, /* IAVF_AQ_RC_ENOSYS */ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #2011: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:341: +#define IAVF_CHECK_STRUCT_LEN(n, X) enum iavf_static_assert_enum_##X \ + { iavf_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #2012: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:342: + { iavf_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ WARNING:TYPO_SPELLING: 'capabilites' may be misspelled - perhaps 'capabilities'? #2103: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:416: +struct iavf_aqc_list_capabilites { WARNING:TYPO_SPELLING: 'capabilites' may be misspelled - perhaps 'capabilities'? #2115: FILE: drivers/net/iavf/base/iavf_adminq_cmd.h:426: +IAVF_CHECK_CMD_LENGTH(iavf_aqc_list_capabilites); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'iavf_set_mac_type', this function's name, in a string #5562: FILE: drivers/net/iavf/base/iavf_common.c:51: + DEBUGFUNC("iavf_set_mac_type "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'iavf_set_mac_type', this function's name, in a string #5586: FILE: drivers/net/iavf/base/iavf_common.c:69: + DEBUGOUT2("iavf_set_mac_type found mac: %d, returns: %d ", CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #8295: FILE: drivers/net/iavf/base/iavf_hmc.h:129: +#define IAVF_SET_PF_SD_ENTRY(hw, pa, sd_index, type) \ { \ u32 val1, val2, val3; \ + val1 = (u32)(IAVF_HI_DWORD(pa)); \ + val2 = (u32)(pa) | (IAVF_HMC_MAX_BP_COUNT << \ + IAVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == IAVF_SD_TYPE_PAGED) ? 0 : 1) << \ + IAVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT) | \ + BIT(IAVF_PFHMC_SDDATALOW_PMSDVALID_SHIFT); \ + val3 = (sd_index) | BIT_ULL(IAVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), IAVF_PFHMC_SDDATAHIGH, val1); \ + wr32((hw), IAVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), IAVF_PFHMC_SDCMD, val3); \ } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pa' - possible side-effects? #8295: FILE: drivers/net/iavf/base/iavf_hmc.h:129: +#define IAVF_SET_PF_SD_ENTRY(hw, pa, sd_index, type) \ { \ u32 val1, val2, val3; \ + val1 = (u32)(IAVF_HI_DWORD(pa)); \ + val2 = (u32)(pa) | (IAVF_HMC_MAX_BP_COUNT << \ + IAVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == IAVF_SD_TYPE_PAGED) ? 0 : 1) << \ + IAVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT) | \ + BIT(IAVF_PFHMC_SDDATALOW_PMSDVALID_SHIFT); \ + val3 = (sd_index) | BIT_ULL(IAVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), IAVF_PFHMC_SDDATAHIGH, val1); \ + wr32((hw), IAVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), IAVF_PFHMC_SDCMD, val3); \ } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #8328: FILE: drivers/net/iavf/base/iavf_hmc.h:150: +#define IAVF_CLEAR_PF_SD_ENTRY(hw, sd_index, type) \ { \ u32 val2, val3; \ + val2 = (IAVF_HMC_MAX_BP_COUNT << \ + IAVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == IAVF_SD_TYPE_PAGED) ? 0 : 1) << \ + IAVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT); \ + val3 = (sd_index) | BIT_ULL(IAVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), IAVF_PFHMC_SDDATAHIGH, 0); \ + wr32((hw), IAVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), IAVF_PFHMC_SDCMD, val3); \ } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmc_info' - possible side-effects? #8379: FILE: drivers/net/iavf/base/iavf_hmc.h:186: +#define IAVF_FIND_SD_INDEX_LIMIT(hmc_info, type, index, cnt, sd_idx, sd_limit)\ { \ u64 fpm_addr, fpm_limit; \ fpm_addr = (hmc_info)->hmc_obj[(type)].base + \ (hmc_info)->hmc_obj[(type)].size * (index); \ fpm_limit = fpm_addr + (hmc_info)->hmc_obj[(type)].size * (cnt);\ + *(sd_idx) = (u32)(fpm_addr / IAVF_HMC_DIRECT_BP_SIZE); \ + *(sd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_DIRECT_BP_SIZE); \ /* add one more to the limit to correct our range */ \ *(sd_limit) += 1; \ } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sd_limit' - possible side-effects? #8379: FILE: drivers/net/iavf/base/iavf_hmc.h:186: +#define IAVF_FIND_SD_INDEX_LIMIT(hmc_info, type, index, cnt, sd_idx, sd_limit)\ { \ u64 fpm_addr, fpm_limit; \ fpm_addr = (hmc_info)->hmc_obj[(type)].base + \ (hmc_info)->hmc_obj[(type)].size * (index); \ fpm_limit = fpm_addr + (hmc_info)->hmc_obj[(type)].size * (cnt);\ + *(sd_idx) = (u32)(fpm_addr / IAVF_HMC_DIRECT_BP_SIZE); \ + *(sd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_DIRECT_BP_SIZE); \ /* add one more to the limit to correct our range */ \ *(sd_limit) += 1; \ } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmc_info' - possible side-effects? #8407: FILE: drivers/net/iavf/base/iavf_hmc.h:210: +#define IAVF_FIND_PD_INDEX_LIMIT(hmc_info, type, idx, cnt, pd_index, pd_limit)\ { \ u64 fpm_adr, fpm_limit; \ fpm_adr = (hmc_info)->hmc_obj[(type)].base + \ (hmc_info)->hmc_obj[(type)].size * (idx); \ fpm_limit = fpm_adr + (hmc_info)->hmc_obj[(type)].size * (cnt); \ + *(pd_index) = (u32)(fpm_adr / IAVF_HMC_PAGED_BP_SIZE); \ + *(pd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_PAGED_BP_SIZE); \ /* add one more to the limit to correct our range */ \ *(pd_limit) += 1; \ } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd_limit' - possible side-effects? #8407: FILE: drivers/net/iavf/base/iavf_hmc.h:210: +#define IAVF_FIND_PD_INDEX_LIMIT(hmc_info, type, idx, cnt, pd_index, pd_limit)\ { \ u64 fpm_adr, fpm_limit; \ fpm_adr = (hmc_info)->hmc_obj[(type)].base + \ (hmc_info)->hmc_obj[(type)].size * (idx); \ fpm_limit = fpm_adr + (hmc_info)->hmc_obj[(type)].size * (cnt); \ + *(pd_index) = (u32)(fpm_adr / IAVF_HMC_PAGED_BP_SIZE); \ + *(pd_limit) = (u32)((fpm_limit - 1) / IAVF_HMC_PAGED_BP_SIZE); \ /* add one more to the limit to correct our range */ \ *(pd_limit) += 1; \ } ERROR:SPACING: space required before the open parenthesis '(' #8686: FILE: drivers/net/iavf/base/iavf_osdep.h:73: +#define ASSERT(x) if(!(x)) rte_panic("IAVF: x") ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #8686: FILE: drivers/net/iavf/base/iavf_osdep.h:73: +#define ASSERT(x) if(!(x)) rte_panic("IAVF: x") CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects? #8746: FILE: drivers/net/iavf/base/iavf_osdep.h:126: +#define iavf_debug(h, m, s, ...) \ do { \ if (((m) & (h)->debug_mask)) \ + PMD_DRV_LOG_RAW(DEBUG, "iavf %02x.%x " s, \ (h)->bus.device, (h)->bus.func, \ ##__VA_ARGS__); \ } while (0) WARNING:LONG_LINE_COMMENT: line over 90 characters #9366: FILE: drivers/net/iavf/base/iavf_register.h:38: +#define IAVFMSIX_PBA1(_i) (0x00002000 + ((_i) * 4)) /* _i=0...19 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9370: FILE: drivers/net/iavf/base/iavf_register.h:42: +#define IAVFMSIX_TADD1(_i) (0x00002100 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #9375: FILE: drivers/net/iavf/base/iavf_register.h:47: +#define IAVFMSIX_TADD1_MSIXTADD_MASK IAVF_MASK(0x3FFFFFFF, IAVFMSIX_TADD1_MSIXTADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9376: FILE: drivers/net/iavf/base/iavf_register.h:48: +#define IAVFMSIX_TMSG1(_i) (0x00002108 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9380: FILE: drivers/net/iavf/base/iavf_register.h:52: +#define IAVFMSIX_TUADD1(_i) (0x00002104 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #9383: FILE: drivers/net/iavf/base/iavf_register.h:55: +#define IAVFMSIX_TUADD1_MSIXTUADD_MASK IAVF_MASK(0xFFFFFFFF, IAVFMSIX_TUADD1_MSIXTUADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9384: FILE: drivers/net/iavf/base/iavf_register.h:56: +#define IAVFMSIX_TVCTRL1(_i) (0x0000210C + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #9439: FILE: drivers/net/iavf/base/iavf_register.h:111: +#define IAVFINT_DYN_CTL01_INTENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_INTENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #9441: FILE: drivers/net/iavf/base/iavf_register.h:113: +#define IAVFINT_DYN_CTL01_CLEARPBA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_CLEARPBA_SHIFT) WARNING:LONG_LINE: line over 90 characters #9443: FILE: drivers/net/iavf/base/iavf_register.h:115: +#define IAVFINT_DYN_CTL01_SWINT_TRIG_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_SWINT_TRIG_SHIFT) WARNING:LONG_LINE: line over 90 characters #9445: FILE: drivers/net/iavf/base/iavf_register.h:117: +#define IAVFINT_DYN_CTL01_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTL01_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #9447: FILE: drivers/net/iavf/base/iavf_register.h:119: +#define IAVFINT_DYN_CTL01_INTERVAL_MASK IAVF_MASK(0xFFF, IAVFINT_DYN_CTL01_INTERVAL_SHIFT) WARNING:LONG_LINE: line over 90 characters #9449: FILE: drivers/net/iavf/base/iavf_register.h:121: +#define IAVFINT_DYN_CTL01_SW_ITR_INDX_ENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_SW_ITR_INDX_ENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #9451: FILE: drivers/net/iavf/base/iavf_register.h:123: +#define IAVFINT_DYN_CTL01_SW_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTL01_SW_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #9453: FILE: drivers/net/iavf/base/iavf_register.h:125: +#define IAVFINT_DYN_CTL01_INTENA_MSK_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_INTENA_MSK_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9454: FILE: drivers/net/iavf/base/iavf_register.h:126: +#define IAVFINT_DYN_CTLN1(_INTVF) (0x00003800 + ((_INTVF) * 4)) /* _i=0...15 */ /* Reset: VFR */ WARNING:LONG_LINE: line over 90 characters #9457: FILE: drivers/net/iavf/base/iavf_register.h:129: +#define IAVFINT_DYN_CTLN1_INTENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_INTENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #9459: FILE: drivers/net/iavf/base/iavf_register.h:131: +#define IAVFINT_DYN_CTLN1_CLEARPBA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_CLEARPBA_SHIFT) WARNING:LONG_LINE: line over 90 characters #9461: FILE: drivers/net/iavf/base/iavf_register.h:133: +#define IAVFINT_DYN_CTLN1_SWINT_TRIG_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_SWINT_TRIG_SHIFT) WARNING:LONG_LINE: line over 90 characters #9463: FILE: drivers/net/iavf/base/iavf_register.h:135: +#define IAVFINT_DYN_CTLN1_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTLN1_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #9465: FILE: drivers/net/iavf/base/iavf_register.h:137: +#define IAVFINT_DYN_CTLN1_INTERVAL_MASK IAVF_MASK(0xFFF, IAVFINT_DYN_CTLN1_INTERVAL_SHIFT) WARNING:LONG_LINE: line over 90 characters #9467: FILE: drivers/net/iavf/base/iavf_register.h:139: +#define IAVFINT_DYN_CTLN1_SW_ITR_INDX_ENA_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_SW_ITR_INDX_ENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #9469: FILE: drivers/net/iavf/base/iavf_register.h:141: +#define IAVFINT_DYN_CTLN1_SW_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_DYN_CTLN1_SW_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #9471: FILE: drivers/net/iavf/base/iavf_register.h:143: +#define IAVFINT_DYN_CTLN1_INTENA_MSK_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_INTENA_MSK_SHIFT) WARNING:LONG_LINE: line over 90 characters #9474: FILE: drivers/net/iavf/base/iavf_register.h:146: +#define IAVFINT_ICR0_ENA1_LINK_STAT_CHANGE_MASK IAVF_MASK(0x1, IAVFINT_ICR0_ENA1_LINK_STAT_CHANGE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9476: FILE: drivers/net/iavf/base/iavf_register.h:148: +#define IAVFINT_ICR0_ENA1_ADMINQ_MASK IAVF_MASK(0x1, IAVFINT_ICR0_ENA1_ADMINQ_SHIFT) WARNING:LONG_LINE: line over 90 characters #9478: FILE: drivers/net/iavf/base/iavf_register.h:150: +#define IAVFINT_ICR0_ENA1_RSVD_MASK IAVF_MASK(0x1, IAVFINT_ICR0_ENA1_RSVD_SHIFT) WARNING:LONG_LINE: line over 90 characters #9491: FILE: drivers/net/iavf/base/iavf_register.h:163: +#define IAVFINT_ICR01_LINK_STAT_CHANGE_MASK IAVF_MASK(0x1, IAVFINT_ICR01_LINK_STAT_CHANGE_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9496: FILE: drivers/net/iavf/base/iavf_register.h:168: +#define IAVFINT_ITR01(_i) (0x00004C00 + ((_i) * 4)) /* _i=0...2 */ /* Reset: VFR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9500: FILE: drivers/net/iavf/base/iavf_register.h:172: +#define IAVFINT_ITRN1(_i, _INTVF) (0x00002800 + ((_i) * 64 + (_INTVF) * 4)) /* _i=0...2, _INTVF=0...15 */ /* Reset: VFR */ WARNING:LONG_LINE: line over 90 characters #9506: FILE: drivers/net/iavf/base/iavf_register.h:178: +#define IAVFINT_STAT_CTL01_OTHER_ITR_INDX_MASK IAVF_MASK(0x3, IAVFINT_STAT_CTL01_OTHER_ITR_INDX_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9507: FILE: drivers/net/iavf/base/iavf_register.h:179: +#define IAVF_QRX_TAIL1(_Q) (0x00002000 + ((_Q) * 4)) /* _i=0...15 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9511: FILE: drivers/net/iavf/base/iavf_register.h:183: +#define IAVF_QTX_TAIL1(_Q) (0x00000000 + ((_Q) * 4)) /* _i=0...15 */ /* Reset: PFR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9518: FILE: drivers/net/iavf/base/iavf_register.h:190: +#define IAVFMSIX_TADD(_i) (0x00000000 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9524: FILE: drivers/net/iavf/base/iavf_register.h:196: +#define IAVFMSIX_TMSG(_i) (0x00000008 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9528: FILE: drivers/net/iavf/base/iavf_register.h:200: +#define IAVFMSIX_TUADD(_i) (0x00000004 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #9531: FILE: drivers/net/iavf/base/iavf_register.h:203: +#define IAVFMSIX_TUADD_MSIXTUADD_MASK IAVF_MASK(0xFFFFFFFF, IAVFMSIX_TUADD_MSIXTUADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9532: FILE: drivers/net/iavf/base/iavf_register.h:204: +#define IAVFMSIX_TVCTRL(_i) (0x0000000C + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #9538: FILE: drivers/net/iavf/base/iavf_register.h:210: +#define IAVFCM_PE_ERRDATA_ERROR_CODE_MASK IAVF_MASK(0xF, IAVFCM_PE_ERRDATA_ERROR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9542: FILE: drivers/net/iavf/base/iavf_register.h:214: +#define IAVFCM_PE_ERRDATA_Q_NUM_MASK IAVF_MASK(0x3FFFF, IAVFCM_PE_ERRDATA_Q_NUM_SHIFT) WARNING:LONG_LINE: line over 90 characters #9545: FILE: drivers/net/iavf/base/iavf_register.h:217: +#define IAVFCM_PE_ERRINFO_ERROR_VALID_MASK IAVF_MASK(0x1, IAVFCM_PE_ERRINFO_ERROR_VALID_SHIFT) WARNING:LONG_LINE: line over 90 characters #9547: FILE: drivers/net/iavf/base/iavf_register.h:219: +#define IAVFCM_PE_ERRINFO_ERROR_INST_MASK IAVF_MASK(0x7, IAVFCM_PE_ERRINFO_ERROR_INST_SHIFT) WARNING:LONG_LINE: line over 90 characters #9549: FILE: drivers/net/iavf/base/iavf_register.h:221: +#define IAVFCM_PE_ERRINFO_DBL_ERROR_CNT_MASK IAVF_MASK(0xFF, IAVFCM_PE_ERRINFO_DBL_ERROR_CNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #9551: FILE: drivers/net/iavf/base/iavf_register.h:223: +#define IAVFCM_PE_ERRINFO_RLU_ERROR_CNT_MASK IAVF_MASK(0xFF, IAVFCM_PE_ERRINFO_RLU_ERROR_CNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #9553: FILE: drivers/net/iavf/base/iavf_register.h:225: +#define IAVFCM_PE_ERRINFO_RLS_ERROR_CNT_MASK IAVF_MASK(0xFF, IAVFCM_PE_ERRINFO_RLS_ERROR_CNT_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #9554: FILE: drivers/net/iavf/base/iavf_register.h:226: +#define IAVFQF_HENA(_i) (0x0000C400 + ((_i) * 4)) /* _i=0...1 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9558: FILE: drivers/net/iavf/base/iavf_register.h:230: +#define IAVFQF_HKEY(_i) (0x0000CC00 + ((_i) * 4)) /* _i=0...12 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9568: FILE: drivers/net/iavf/base/iavf_register.h:240: +#define IAVFQF_HLUT(_i) (0x0000D000 + ((_i) * 4)) /* _i=0...15 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #9578: FILE: drivers/net/iavf/base/iavf_register.h:250: +#define IAVFQF_HREGION(_i) (0x0000D400 + ((_i) * 4)) /* _i=0...7 */ /* Reset: CORER */ WARNING:LONG_LINE: line over 90 characters #9581: FILE: drivers/net/iavf/base/iavf_register.h:253: +#define IAVFQF_HREGION_OVERRIDE_ENA_0_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_0_SHIFT) WARNING:LONG_LINE: line over 90 characters #9585: FILE: drivers/net/iavf/base/iavf_register.h:257: +#define IAVFQF_HREGION_OVERRIDE_ENA_1_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_1_SHIFT) WARNING:LONG_LINE: line over 90 characters #9589: FILE: drivers/net/iavf/base/iavf_register.h:261: +#define IAVFQF_HREGION_OVERRIDE_ENA_2_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_2_SHIFT) WARNING:LONG_LINE: line over 90 characters #9593: FILE: drivers/net/iavf/base/iavf_register.h:265: +#define IAVFQF_HREGION_OVERRIDE_ENA_3_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_3_SHIFT) WARNING:LONG_LINE: line over 90 characters #9597: FILE: drivers/net/iavf/base/iavf_register.h:269: +#define IAVFQF_HREGION_OVERRIDE_ENA_4_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_4_SHIFT) WARNING:LONG_LINE: line over 90 characters #9601: FILE: drivers/net/iavf/base/iavf_register.h:273: +#define IAVFQF_HREGION_OVERRIDE_ENA_5_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_5_SHIFT) WARNING:LONG_LINE: line over 90 characters #9605: FILE: drivers/net/iavf/base/iavf_register.h:277: +#define IAVFQF_HREGION_OVERRIDE_ENA_6_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_6_SHIFT) WARNING:LONG_LINE: line over 90 characters #9609: FILE: drivers/net/iavf/base/iavf_register.h:281: +#define IAVFQF_HREGION_OVERRIDE_ENA_7_MASK IAVF_MASK(0x1, IAVFQF_HREGION_OVERRIDE_ENA_7_SHIFT) WARNING:LONG_LINE: line over 90 characters #9674: FILE: drivers/net/iavf/base/iavf_register.h:286: +#define IAVFINT_DYN_CTL01_WB_ON_ITR_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTL01_WB_ON_ITR_SHIFT) WARNING:LONG_LINE: line over 90 characters #9676: FILE: drivers/net/iavf/base/iavf_register.h:288: +#define IAVFINT_DYN_CTLN1_WB_ON_ITR_MASK IAVF_MASK(0x1, IAVFINT_DYN_CTLN1_WB_ON_ITR_SHIFT) WARNING:LONG_LINE: line over 90 characters #9679: FILE: drivers/net/iavf/base/iavf_register.h:291: +#define IAVFPE_AEQALLOC1_AECOUNT_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_AEQALLOC1_AECOUNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #9682: FILE: drivers/net/iavf/base/iavf_register.h:294: +#define IAVFPE_CCQPHIGH1_PECCQPHIGH_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_CCQPHIGH1_PECCQPHIGH_SHIFT) WARNING:LONG_LINE: line over 90 characters #9685: FILE: drivers/net/iavf/base/iavf_register.h:297: +#define IAVFPE_CCQPLOW1_PECCQPLOW_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_CCQPLOW1_PECCQPLOW_SHIFT) WARNING:LONG_LINE: line over 90 characters #9688: FILE: drivers/net/iavf/base/iavf_register.h:300: +#define IAVFPE_CCQPSTATUS1_CCQP_DONE_MASK IAVF_MASK(0x1, IAVFPE_CCQPSTATUS1_CCQP_DONE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9690: FILE: drivers/net/iavf/base/iavf_register.h:302: +#define IAVFPE_CCQPSTATUS1_HMC_PROFILE_MASK IAVF_MASK(0x7, IAVFPE_CCQPSTATUS1_HMC_PROFILE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9692: FILE: drivers/net/iavf/base/iavf_register.h:304: +#define IAVFPE_CCQPSTATUS1_RDMA_EN_VFS_MASK IAVF_MASK(0x3F, IAVFPE_CCQPSTATUS1_RDMA_EN_VFS_SHIFT) WARNING:LONG_LINE: line over 90 characters #9694: FILE: drivers/net/iavf/base/iavf_register.h:306: +#define IAVFPE_CCQPSTATUS1_CCQP_ERR_MASK IAVF_MASK(0x1, IAVFPE_CCQPSTATUS1_CCQP_ERR_SHIFT) WARNING:LONG_LINE: line over 90 characters #9706: FILE: drivers/net/iavf/base/iavf_register.h:318: +#define IAVFPE_CQPERRCODES1_CQP_MINOR_CODE_MASK IAVF_MASK(0xFFFF, IAVFPE_CQPERRCODES1_CQP_MINOR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9708: FILE: drivers/net/iavf/base/iavf_register.h:320: +#define IAVFPE_CQPERRCODES1_CQP_MAJOR_CODE_MASK IAVF_MASK(0xFFFF, IAVFPE_CQPERRCODES1_CQP_MAJOR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9716: FILE: drivers/net/iavf/base/iavf_register.h:328: +#define IAVFPE_IPCONFIG01_PEIPID_MASK IAVF_MASK(0xFFFF, IAVFPE_IPCONFIG01_PEIPID_SHIFT) WARNING:LONG_LINE: line over 90 characters #9718: FILE: drivers/net/iavf/base/iavf_register.h:330: +#define IAVFPE_IPCONFIG01_USEENTIREIDRANGE_MASK IAVF_MASK(0x1, IAVFPE_IPCONFIG01_USEENTIREIDRANGE_SHIFT) WARNING:LONG_LINE: line over 90 characters #9721: FILE: drivers/net/iavf/base/iavf_register.h:333: +#define IAVFPE_MRTEIDXMASK1_MRTEIDXMASKBITS_MASK IAVF_MASK(0x1F, IAVFPE_MRTEIDXMASK1_MRTEIDXMASKBITS_SHIFT) WARNING:LONG_LINE: line over 90 characters #9724: FILE: drivers/net/iavf/base/iavf_register.h:336: +#define IAVFPE_RCVUNEXPECTEDERROR1_TCP_RX_UNEXP_ERR_MASK IAVF_MASK(0xFFFFFF, IAVFPE_RCVUNEXPECTEDERROR1_TCP_RX_UNEXP_ERR_SHIFT) WARNING:LONG_LINE: line over 90 characters #9727: FILE: drivers/net/iavf/base/iavf_register.h:339: +#define IAVFPE_TCPNOWTIMER1_TCP_NOW_MASK IAVF_MASK(0xFFFFFFFF, IAVFPE_TCPNOWTIMER1_TCP_NOW_SHIFT) WARNING:LONG_LINE: line over 90 characters #9730: FILE: drivers/net/iavf/base/iavf_register.h:342: +#define IAVFPE_WQEALLOC1_PEQPID_MASK IAVF_MASK(0x3FFFF, IAVFPE_WQEALLOC1_PEQPID_SHIFT) WARNING:LONG_LINE: line over 90 characters #9732: FILE: drivers/net/iavf/base/iavf_register.h:344: +#define IAVFPE_WQEALLOC1_WQE_DESC_INDEX_MASK IAVF_MASK(0xFFF, IAVFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mask' may be better as '(mask)' to avoid precedence issues #9914: FILE: drivers/net/iavf/base/iavf_type.h:63: +#define IAVF_MASK(mask, shift) (mask << shift) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'shift' may be better as '(shift)' to avoid precedence issues #9914: FILE: drivers/net/iavf/base/iavf_type.h:63: +#define IAVF_MASK(mask, shift) (mask << shift) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'address' - possible side-effects? #9950: FILE: drivers/net/iavf/base/iavf_type.h:87: +#define IAVF_IS_BROADCAST(address) \ ((((u8 *)(address))[0] == ((u8)0xff)) && \ (((u8 *)(address))[1] == ((u8)0xff))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'R' - possible side-effects? #9993: FILE: drivers/net/iavf/base/iavf_type.h:118: +#define IAVF_DESC_UNUSED(R) \ ((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->count) + \ (R)->next_to_clean - (R)->next_to_use - 1) CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #13486: FILE: drivers/net/iavf/iavf_ethdev.c:326: + interval = iavf_calc_itr_interval( CHECK:CAMELCASE: Avoid CamelCase: #14521: FILE: drivers/net/iavf/iavf_ethdev.c:1365: + snprintf(z_name, sizeof(z_name), "iavf_dma_%"PRIu64, rte_rand()); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #14521: FILE: drivers/net/iavf/iavf_ethdev.c:1365: + snprintf(z_name, sizeof(z_name), "iavf_dma_%"PRIu64, rte_rand()); ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #16242: FILE: drivers/net/iavf/iavf_rxtx.h:25: +#define IAVF_NO_VECTOR_FLAGS ( \ DEV_TX_OFFLOAD_MULTI_SEGS | \ DEV_TX_OFFLOAD_VLAN_INSERT | \ DEV_TX_OFFLOAD_SCTP_CKSUM | \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #16266: FILE: drivers/net/iavf/iavf_rxtx.h:45: +#define IAVF_TX_OFFLOAD_MASK ( \ PKT_TX_OUTER_IPV6 | \ PKT_TX_OUTER_IPV4 | \ PKT_TX_IPV6 | \ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #16474: FILE: drivers/net/iavf/iavf_rxtx.h:238: + type = (enum iavf_tx_desc_dtype_value)rte_le_to_cpu_64( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #17029: FILE: drivers/net/iavf/iavf_vchnl.c:204: + msg_ret = (enum iavf_status_code)rte_le_to_cpu_32( total: 4 errors, 80 warnings, 17008 lines checked