From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rosen Xu <rosen.xu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw50619 [v1, 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver
Date: Thu, 28 Feb 2019 08:15:51 +0100 (CET) [thread overview]
Message-ID: <20190228071551.B41241B205@dpdk.org> (raw)
In-Reply-To: <1551338000-120348-6-git-send-email-rosen.xu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50619
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == MAP_UUID_10G_LOW'
#383: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:278:
+ if ((afu_dev->id.uuid.uuid_low == MAP_UUID_10G_LOW) &&
+ (afu_dev->id.uuid.uuid_high == MAP_UUID_10G_HIGH)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == MAP_UUID_10G_HIGH'
#383: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:278:
+ if ((afu_dev->id.uuid.uuid_low == MAP_UUID_10G_LOW) &&
+ (afu_dev->id.uuid.uuid_high == MAP_UUID_10G_HIGH)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == MAP_UUID_10G_LOW'
#474: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:369:
+ if ((afu_dev->id.uuid.uuid_low == MAP_UUID_10G_LOW) &&
+ (afu_dev->id.uuid.uuid_high == MAP_UUID_10G_HIGH)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == MAP_UUID_10G_HIGH'
#474: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:369:
+ if ((afu_dev->id.uuid.uuid_low == MAP_UUID_10G_LOW) &&
+ (afu_dev->id.uuid.uuid_high == MAP_UUID_10G_HIGH)) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#626: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:521:
+ if (!afu_dev->shared.data) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#642: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:537:
+ } else
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_x' - possible side-effects?
#2665: FILE: drivers/net/ipn3ke/ipn3ke_flow.c:992:
+#define __SWAP16(_x) \
+ ((((_x) & 0xff) << 8) | \
+ (((_x) >> 8) & 0xff))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_x' - possible side-effects?
#2669: FILE: drivers/net/ipn3ke/ipn3ke_flow.c:996:
+#define __SWAP32(_x) \
+ ((__SWAP16((_x) & 0xffff) << 16) | \
+ __SWAP16(((_x) >> 16) & 0xffff))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size < ETHER_MIN_MTU'
#3939: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:707:
+ if ((frame_size < ETHER_MIN_MTU) ||
+ (frame_size > IPN3KE_MAC_FRAME_SIZE_MAX))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > IPN3KE_MAC_FRAME_SIZE_MAX'
#3939: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:707:
+ if ((frame_size < ETHER_MIN_MTU) ||
+ (frame_size > IPN3KE_MAC_FRAME_SIZE_MAX))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4094: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:862:
+ IPN3KE_AFU_PMD_ERR(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != RTE_TM_NODE_ID_NULL'
#4469: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:341:
+ if ((n->tm_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node != NULL) ||
+ (n->n_children > 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id != RTE_TM_NODE_ID_NULL'
#4469: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:341:
+ if ((n->tm_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node != NULL) ||
+ (n->n_children > 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node != NULL'
#4469: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:341:
+ if ((n->tm_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node != NULL) ||
+ (n->n_children > 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->n_children > 0'
#4469: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:341:
+ if ((n->tm_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->parent_node != NULL) ||
+ (n->n_children > 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id == RTE_TM_NODE_ID_NULL'
#4478: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:350:
+ if ((n->tm_id == RTE_TM_NODE_ID_NULL) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node_id == RTE_TM_NODE_ID_NULL)) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node == NULL))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT'
#4478: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:350:
+ if ((n->tm_id == RTE_TM_NODE_ID_NULL) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node_id == RTE_TM_NODE_ID_NULL)) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node == NULL))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id == RTE_TM_NODE_ID_NULL'
#4478: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:350:
+ if ((n->tm_id == RTE_TM_NODE_ID_NULL) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node_id == RTE_TM_NODE_ID_NULL)) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node == NULL))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT'
#4478: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:350:
+ if ((n->tm_id == RTE_TM_NODE_ID_NULL) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node_id == RTE_TM_NODE_ID_NULL)) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node == NULL))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node == NULL'
#4478: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:350:
+ if ((n->tm_id == RTE_TM_NODE_ID_NULL) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node_id == RTE_TM_NODE_ID_NULL)) ||
+ ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) &&
+ (n->parent_node == NULL))) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#4493: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:365:
+ if (IPN3KE_BIT_ISSET(state_mask, n->node_state)) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#4500: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:372:
+ } else
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'node == NULL'
#4529: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:401:
+ if (node_id == RTE_TM_NODE_ID_NULL ||
+ (node == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rate >= r->low'
#4836: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:708:
+ if ((rate >= r->low) &&
+ (rate <= r->high)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rate <= r->high'
#4836: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:708:
+ if ((rate >= r->low) &&
+ (rate <= r->high)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id != RTE_TM_SHAPER_PROFILE_ID_NONE'
#5337: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1209:
+ if ((params->shaper_profile_id != RTE_TM_SHAPER_PROFILE_ID_NONE) &&
+ (params->shaper_profile_id != node_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id != node_id'
#5337: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1209:
+ if ((params->shaper_profile_id != RTE_TM_SHAPER_PROFILE_ID_NONE) &&
+ (params->shaper_profile_id != node_id))
CHECK:BRACES: braces {} should be used on all arms of this statement
#5362: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1234:
+ if (parent_node_id != RTE_TM_NODE_ID_NULL) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#5373: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1245:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#5556: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1428:
+ if (n->parent_node_id != RTE_TM_NODE_ID_NULL) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#5576: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1448:
+ } else
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id == RTE_TM_NODE_ID_NULL'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_COS'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != tm_id'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node == NULL'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state ==
IPN3KE_TM_NODE_STATE_CONFIGURED_DEL'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state ==
IPN3KE_TM_NODE_STATE_IDLE'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->shaper_profile.valid == 0'
#5655: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1527:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_COS'
#5672: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1544:
+ if ((n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->n_children != 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->n_children != 0'
#5672: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1544:
+ if ((n->level != IPN3KE_TM_NODE_LEVEL_COS) ||
+ (n->n_children != 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id == RTE_TM_NODE_ID_NULL'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_VT'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != tm_id'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node == NULL'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state ==
IPN3KE_TM_NODE_STATE_CONFIGURED_DEL'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state ==
IPN3KE_TM_NODE_STATE_IDLE'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->shaper_profile.valid == 0'
#5692: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1564:
+ if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->tm_id != tm_id) ||
+ (parent_node == NULL) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) ||
+ (parent_node &&
+ (parent_node->node_state ==
+ IPN3KE_TM_NODE_STATE_IDLE)) ||
+ (n->shaper_profile.valid == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_VT'
#5709: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1581:
+ if ((n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->n_children != 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->n_children != 0'
#5709: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1581:
+ if ((n->level != IPN3KE_TM_NODE_LEVEL_VT) ||
+ (n->n_children != 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id != RTE_TM_NODE_ID_NULL'
#5725: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1597:
+ if (n &&
+ ((n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_PORT) ||
+ (n->tm_id != tm_id) ||
+ (n->parent_node != NULL) ||
+ (n->shaper_profile.valid == 0)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_PORT'
#5725: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1597:
+ if (n &&
+ ((n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_PORT) ||
+ (n->tm_id != tm_id) ||
+ (n->parent_node != NULL) ||
+ (n->shaper_profile.valid == 0)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != tm_id'
#5725: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1597:
+ if (n &&
+ ((n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_PORT) ||
+ (n->tm_id != tm_id) ||
+ (n->parent_node != NULL) ||
+ (n->shaper_profile.valid == 0)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node != NULL'
#5725: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1597:
+ if (n &&
+ ((n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_PORT) ||
+ (n->tm_id != tm_id) ||
+ (n->parent_node != NULL) ||
+ (n->shaper_profile.valid == 0)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->shaper_profile.valid == 0'
#5725: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1597:
+ if (n &&
+ ((n->parent_node_id != RTE_TM_NODE_ID_NULL) ||
+ (n->level != IPN3KE_TM_NODE_LEVEL_PORT) ||
+ (n->tm_id != tm_id) ||
+ (n->parent_node != NULL) ||
+ (n->shaper_profile.valid == 0)))
CHECK:BRACES: Unbalanced braces around else statement
#5929: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1801:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#5958: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1830:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#5992: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1864:
+ } else
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#6460: FILE: drivers/net/ipn3ke/ipn3ke_tm.h:109:
+#define IPN3KE_TM_COS_NODE_NUM (64*1024)
^
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#6461: FILE: drivers/net/ipn3ke/ipn3ke_tm.h:110:
+#define IPN3KE_TM_VT_NODE_NUM (IPN3KE_TM_COS_NODE_NUM/8)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#6468: FILE: drivers/net/ipn3ke/ipn3ke_tm.h:117:
+#define IPN3KE_TM_TDROP_PROFILE_NUM (2*1024)
^
total: 0 errors, 0 warnings, 60 checks, 6392 lines checked
parent reply other threads:[~2019-02-28 7:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1551338000-120348-6-git-send-email-rosen.xu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228071551.B41241B205@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).