From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [dpdk-test-report] |WARNING| pw51275 [PATCH v2 2/4] crypto/qat: add asymmetric cryptography PMD
Date: Mon, 18 Mar 2019 13:47:30 +0100 (CET) [thread overview]
Message-ID: <20190318124730.26D5E4CC7@dpdk.org> (raw)
In-Reply-To: <20190318124515.4660-3-arkadiuszx.kusztal@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/51275
_coding style issues_
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#203: FILE: drivers/crypto/qat/qat_asym.c:14:
+static int __rte_unused qat_asym_get_sz_and_func_id(const uint32_t arr[][2],
+ size_t arr_sz, size_t *size, uint32_t *func_id) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#217: FILE: drivers/crypto/qat/qat_asym.c:28:
+static void qat_asym_build_req_tmpl(void *sess_private_data,
+ struct rte_crypto_asym_xform __rte_unused *xform) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#260: FILE: drivers/crypto/qat/qat_asym.c:71:
+static void __rte_unused qat_clear_arrays(struct qat_asym_op_cookie *cookie, int in_count,
+ int out_count, int in_size, int out_size) {
WARNING:TYPO_SPELLING: 'lenght' may be misspelled - perhaps 'length'?
#273: FILE: drivers/crypto/qat/qat_asym.c:84:
+ * generator which very often can be of one byte lenght */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#273: FILE: drivers/crypto/qat/qat_asym.c:84:
+ * generator which very often can be of one byte lenght */
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#564: FILE: drivers/crypto/qat/qat_asym_pmd.c:23:
+int
WARNING:LONG_LINE: line over 90 characters
#723: FILE: drivers/crypto/qat/qat_asym_pmd.c:182:
+ offsetof(struct qat_asym_op_cookie, input_array[j]);
WARNING:LONG_LINE: line over 90 characters
#725: FILE: drivers/crypto/qat/qat_asym_pmd.c:184:
+ offsetof(struct qat_asym_op_cookie, output_array[j]);
total: 3 errors, 5 warnings, 807 lines checked
parent reply other threads:[~2019-03-18 12:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190318124515.4660-3-arkadiuszx.kusztal@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318124730.26D5E4CC7@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arkadiuszx.kusztal@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).