From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Morten Brørup" <mb@smartsharesystems.com>
Subject: [dpdk-test-report] |WARNING| pw53373 [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h
Date: Fri, 10 May 2019 18:22:31 +0200 (CEST) [thread overview]
Message-ID: <20190510162231.1E3084C90@dpdk.org> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B4283D@smartserver.smartshare.dk>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53373
_coding style issues_
ERROR:DOS_LINE_ENDINGS: DOS line endings
#47: FILE: app/test-pmd/cmdline.c:9986:
+^Iif (res->tcp_flags_value > RTE_NTUPLE_TCP_FLAGS_MASK) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#56: FILE: app/test-pmd/cmdline.c:10144:
+^Iif (res->tcp_flags_value > RTE_NTUPLE_TCP_FLAGS_MASK) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: drivers/net/e1000/igb_ethdev.c:3705:
+^Iif (filter->tcp_flags > RTE_NTUPLE_TCP_FLAGS_MASK)^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#78: FILE: drivers/net/e1000/igb_ethdev.c:3785:
+^Iif (filter->filter_info.tcp_flags & RTE_NTUPLE_TCP_FLAGS_MASK) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#87: FILE: drivers/net/e1000/igb_ethdev.c:4191:
+^Iif (filter->tcp_flags > RTE_NTUPLE_TCP_FLAGS_MASK)^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#96: FILE: drivers/net/e1000/igb_ethdev.c:4321:
+^Iif (filter->filter_info.tcp_flags & RTE_NTUPLE_TCP_FLAGS_MASK) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: lib/librte_ethdev/rte_eth_ctrl.h:187:
+#define RTE_NTUPLE_TCP_FLAGS_MASK 0x3F /**< TCP flags filter can match. */^M$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#127: FILE: lib/librte_net/rte_tcp.h:5:
+ * Copyright(c) 2019 SmartShare Systems.^M$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#135: FILE: lib/librte_net/rte_tcp.h:39:
+/**^M$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#136: FILE: lib/librte_net/rte_tcp.h:40:
+ * TCP Flags^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#137: FILE: lib/librte_net/rte_tcp.h:41:
+ */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#138: FILE: lib/librte_net/rte_tcp.h:42:
+#define TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#139: FILE: lib/librte_net/rte_tcp.h:43:
+#define TCP_ECE_FLAG 0x40 /**< ECN-Echo */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#140: FILE: lib/librte_net/rte_tcp.h:44:
+#define TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#141: FILE: lib/librte_net/rte_tcp.h:45:
+#define TCP_ACK_FLAG 0x10 /**< Acknowledgment field significant */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#142: FILE: lib/librte_net/rte_tcp.h:46:
+#define TCP_PSH_FLAG 0x08 /**< Push Function */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#143: FILE: lib/librte_net/rte_tcp.h:47:
+#define TCP_RST_FLAG 0x04 /**< Reset the connection */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#144: FILE: lib/librte_net/rte_tcp.h:48:
+#define TCP_SYN_FLAG 0x02 /**< Synchronize sequence numbers */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#145: FILE: lib/librte_net/rte_tcp.h:49:
+#define TCP_FIN_FLAG 0x01 /**< No more data from sender */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#146: FILE: lib/librte_net/rte_tcp.h:50:
+^M$
total: 20 errors, 0 warnings, 87 lines checked
parent reply other threads:[~2019-05-10 16:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <98CBD80474FA8B44BF855DF32C47DC35B4283D@smartserver.smartshare.dk>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510162231.1E3084C90@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).