From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw53561 [PATCH 03/11] net/hinic/base: add mgmt module interactive code
Date: Tue, 21 May 2019 10:09:02 +0200 (CEST) [thread overview]
Message-ID: <20190521080902.B4B6E56A3@dpdk.org> (raw)
In-Reply-To: <1558426753-187020-1-git-send-email-xuanziyang2@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53561
_coding style issues_
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#82: FILE: drivers/net/hinic/base/hinic_pmd_hw_mgmt.h:43:
+ bool lro_en; /* LRO feature enable bit */
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#163: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:33:
+#define SYNC_MSG_ID_INC(pf_to_mgmt) (SYNC_MSG_ID(pf_to_mgmt) = \
+ (SYNC_MSG_ID(pf_to_mgmt) + 1) & SYNC_MSG_ID_MASK)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#168: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:38:
+#define ASYNC_MSG_ID_INC(pf_to_mgmt) (ASYNC_MSG_ID(pf_to_mgmt) = \
+ ((ASYNC_MSG_ID(pf_to_mgmt) + 1) & ASYNC_MSG_ID_MASK) \
+ | ASYNC_MSG_FLAG)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'recv_msg->msg_len'
#543: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:413:
+ if ((recv_msg->msg_len) && (buf_out) && (out_size)) {
total: 0 errors, 0 warnings, 4 checks, 1332 lines checked
parent reply other threads:[~2019-05-21 8:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1558426753-187020-1-git-send-email-xuanziyang2@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521080902.B4B6E56A3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=xuanziyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).