* [dpdk-test-report] |WARNING| pw53561 [PATCH 03/11] net/hinic/base: add mgmt module interactive code
[not found] <1558426753-187020-1-git-send-email-xuanziyang2@huawei.com>
@ 2019-05-21 8:09 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-05-21 8:09 UTC (permalink / raw)
To: test-report; +Cc: Ziyang Xuan
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53561
_coding style issues_
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#82: FILE: drivers/net/hinic/base/hinic_pmd_hw_mgmt.h:43:
+ bool lro_en; /* LRO feature enable bit */
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#163: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:33:
+#define SYNC_MSG_ID_INC(pf_to_mgmt) (SYNC_MSG_ID(pf_to_mgmt) = \
+ (SYNC_MSG_ID(pf_to_mgmt) + 1) & SYNC_MSG_ID_MASK)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#168: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:38:
+#define ASYNC_MSG_ID_INC(pf_to_mgmt) (ASYNC_MSG_ID(pf_to_mgmt) = \
+ ((ASYNC_MSG_ID(pf_to_mgmt) + 1) & ASYNC_MSG_ID_MASK) \
+ | ASYNC_MSG_FLAG)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'recv_msg->msg_len'
#543: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:413:
+ if ((recv_msg->msg_len) && (buf_out) && (out_size)) {
total: 0 errors, 0 warnings, 4 checks, 1332 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-21 8:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1558426753-187020-1-git-send-email-xuanziyang2@huawei.com>
2019-05-21 8:09 ` [dpdk-test-report] |WARNING| pw53561 [PATCH 03/11] net/hinic/base: add mgmt module interactive code checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).