automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw55018 [PATCH v5 05/15] net/hinic/base: add eq mechanism function code
Date: Wed, 19 Jun 2019 17:45:45 +0200 (CEST)	[thread overview]
Message-ID: <20190619154545.8579C1D115@dpdk.org> (raw)
In-Reply-To: <0b2dd974286b662bd665b6e798cf288e76be5c4b.1560958308.git.xuanziyang2@huawei.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55018

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#127: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:90:
+#define EQ_CONS_IDX(eq)		((eq)->cons_idx | \
+				((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#130: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:93:
+#define EQ_CONS_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#134: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:97:
+#define EQ_PROD_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#138: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:101:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#138: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:101:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#159: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:122:
+#define aeq_to_aeqs(eq) \
+		container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#679: FILE: drivers/net/hinic/base/hinic_pmd_eqs.h:27:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#679: FILE: drivers/net/hinic/base/hinic_pmd_eqs.h:27:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

total: 0 errors, 0 warnings, 8 checks, 710 lines checked

           reply	other threads:[~2019-06-19 15:45 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <0b2dd974286b662bd665b6e798cf288e76be5c4b.1560958308.git.xuanziyang2@huawei.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619154545.8579C1D115@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=xuanziyang2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).