From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 86085A0471 for ; Wed, 19 Jun 2019 17:45:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 536201D0FC; Wed, 19 Jun 2019 17:45:47 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 8579C1D115; Wed, 19 Jun 2019 17:45:45 +0200 (CEST) In-Reply-To: <0b2dd974286b662bd665b6e798cf288e76be5c4b.1560958308.git.xuanziyang2@huawei.com> References: <0b2dd974286b662bd665b6e798cf288e76be5c4b.1560958308.git.xuanziyang2@huawei.com> To: test-report@dpdk.org Cc: Ziyang Xuan Message-Id: <20190619154545.8579C1D115@dpdk.org> Date: Wed, 19 Jun 2019 17:45:45 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw55018 [PATCH v5 05/15] net/hinic/base: add eq mechanism function code X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/55018 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #127: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:90: +#define EQ_CONS_IDX(eq) ((eq)->cons_idx | \ + ((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #130: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:93: +#define EQ_CONS_IDX_REG_ADDR(eq) (((eq)->type == HINIC_AEQ) ? \ + HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\ + HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #134: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:97: +#define EQ_PROD_IDX_REG_ADDR(eq) (((eq)->type == HINIC_AEQ) ? \ + HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\ + HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #138: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:101: +#define GET_EQ_NUM_PAGES(eq, size) \ + ((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \ + / (size))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects? #138: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:101: +#define GET_EQ_NUM_PAGES(eq, size) \ + ((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \ + / (size))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #159: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:122: +#define aeq_to_aeqs(eq) \ + container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0]) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #679: FILE: drivers/net/hinic/base/hinic_pmd_eqs.h:27: +#define GET_EQ_ELEMENT(eq, idx) \ + (((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \ + (((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #679: FILE: drivers/net/hinic/base/hinic_pmd_eqs.h:27: +#define GET_EQ_ELEMENT(eq, idx) \ + (((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \ + (((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size)) total: 0 errors, 0 warnings, 8 checks, 710 lines checked