From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CB704A00E6
	for <public@inbox.dpdk.org>; Mon,  8 Jul 2019 05:10:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C03ED1C01;
	Mon,  8 Jul 2019 05:10:40 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 79F3B4C90; Mon,  8 Jul 2019 05:10:40 +0200 (CEST)
In-Reply-To: <1562554988-17394-1-git-send-email-andy.pei@intel.com>
References: <1562554988-17394-1-git-send-email-andy.pei@intel.com>
To: test-report@dpdk.org
Cc: Andy Pei <andy.pei@intel.com>
Message-Id: <20190708031040.79F3B4C90@dpdk.org>
Date: Mon,  8 Jul 2019 05:10:40 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw56199 [PATCH v4] net/i40e: i40e get
	link status update from ipn3ke
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56199

_coding style issues_


WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#89: FILE: drivers/net/i40e/i40e_ethdev.c:636:
+	if (RTE_ETH_NAME_MAX_LEN > strlen(value)) {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#92: FILE: drivers/net/i40e/i40e_ethdev.c:639:
+		return 0;
+	} else {

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#174: FILE: drivers/net/i40e/i40e_ethdev.c:721:
+					i40e_eth_dev_get_by_switch_mode_name(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#193: FILE: drivers/net/i40e/i40e_ethdev.c:740:
+		switch_ethdev = i40e_get_switch_ethdev_from_devargs(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#254: FILE: drivers/net/i40e/i40e_ethdev.c:2931:
+				i40e_get_switch_ethdev_from_devargs(

total: 0 errors, 2 warnings, 208 lines checked