automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw56953 [PATCH v5 1/3] vfio: revert change that does intr eventfd setup at probe
Date: Tue, 23 Jul 2019 10:04:41 +0200 (CEST)	[thread overview]
Message-ID: <20190723080441.A8A811BFC4@dpdk.org> (raw)
In-Reply-To: <1563869059-12618-2-git-send-email-david.marchand@redhat.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56953

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#105: FILE: drivers/bus/pci/linux/pci_vfio.c:246:
+				return -1;
+			} else

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#324: FILE: lib/librte_eal/linux/eal/eal_interrupts.c:230:
+static int
+vfio_disable_msi(const struct rte_intr_handle *intr_handle) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#351: FILE: lib/librte_eal/linux/eal/eal_interrupts.c:255:
+static int
+vfio_enable_msix(const struct rte_intr_handle *intr_handle) {

total: 2 errors, 1 warnings, 362 lines checked

           reply	other threads:[~2019-07-23  8:04 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1563869059-12618-2-git-send-email-david.marchand@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723080441.A8A811BFC4@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).