From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: JinYu <jin.yu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw57323 [PATCH v4 2/2] vhost: Add vhost-user-blk example which support inflight
Date: Wed, 31 Jul 2019 14:58:16 +0200 (CEST) [thread overview]
Message-ID: <20190731125816.2B98B1C1A4@dpdk.org> (raw)
In-Reply-To: <20190731204050.40633-3-jin.yu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57323
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#473: FILE: examples/vhost_blk/vhost_blk.c:96:
+ if (!!(cur_desc->flags & VIRTQ_DESC_F_NEXT)) {
+ return &inflight_packed->desc[cur_desc->next];
+ }
WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#820: FILE: examples/vhost_blk/vhost_blk.c:443:
+ chunck_len = task->inflight_desc->len;;
ERROR:TRAILING_WHITESPACE: trailing whitespace
#901: FILE: examples/vhost_blk/vhost_blk.c:524:
+^Iwhile (j++ < 1000000 && $
WARNING:LONG_LINE: line over 90 characters
#923: FILE: examples/vhost_blk/vhost_blk.c:546:
+ task[i]->desc_packed = descriptor_get_next_packed(task[i]->vq, &avail_idx);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#955: FILE: examples/vhost_blk/vhost_blk.c:578:
+ if (g_should_stop == 1) {
+ goto free_task;
+ }
WARNING:LONG_LINE: line over 90 characters
#1253: FILE: examples/vhost_blk/vhost_blk.c:876:
+ while (j++ < 1000000 && vq->avail->idx != blk_vq->last_avail_idx && i < MAX_TASK) {
WARNING:LONG_LINE: line over 90 characters
#1263: FILE: examples/vhost_blk/vhost_blk.c:886:
+ rte_vhost_set_inflight_desc_split(ctrlr->bdev->vid, q_idx, task[i]->req_idx);
ERROR:SPACING: space required before the open parenthesis '('
#1476: FILE: examples/vhost_blk/vhost_blk.c:1099:
+ while(g_should_stop != 2);
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1476: FILE: examples/vhost_blk/vhost_blk.c:1099:
+ while(g_should_stop != 2);
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'JinYu <jin.yu@intel.com>'
total: 3 errors, 7 warnings, 1883 lines checked
parent reply other threads:[~2019-07-31 12:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190731204050.40633-3-jin.yu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731125816.2B98B1C1A4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jin.yu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).