automatic DPDK test reports
 help / color / Atom feed
* [dpdk-test-report] |WARNING| pw57670 [RFC 5/5] app: add test-sad application
       [not found] <1565709186-273340-6-git-send-email-vladimir.medvedkin@intel.com>
@ 2019-08-13 15:13 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-08-13 15:13 UTC (permalink / raw)
  To: test-report; +Cc: Vladimir Medvedkin

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57670

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#110: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {		\
+	unsigned long val;					\
+	char *end_fld;						\
+	errno = 0;						\
+	val = strtoul((in), &end_fld, (base));			\
+	if (errno != 0 || end_fld[0] != (dlm) || val > (lim))	\
+		return -EINVAL;					\
+	(fd) = (typeof(fd))val;					\
+	(in) = end_fld + 1;					\
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#288: FILE: app/test-sad/main.c:202:
+	unsigned i, rnd;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#433: FILE: app/test-sad/main.c:347:
+	unsigned i;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#448: FILE: app/test-sad/main.c:362:
+	printf("Average lookup cycles %lu
", acc / config.nb_tuples);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#455: FILE: app/test-sad/main.c:369:
+	unsigned i;

total: 0 errors, 5 warnings, 460 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1565709186-273340-6-git-send-email-vladimir.medvedkin@intel.com>
2019-08-13 15:13 ` [dpdk-test-report] |WARNING| pw57670 [RFC 5/5] app: add test-sad application checkpatch

automatic DPDK test reports

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ http://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/ public-inbox