automatic DPDK test reports
 help / color / Atom feed
* [dpdk-test-report] |WARNING| pw57675 [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare exchange
       [not found] <1565771263-27353-1-git-send-email-phil.yang@arm.com>
@ 2019-08-14  8:30 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-08-14  8:30 UTC (permalink / raw)
  To: test-report; +Cc: Phil Yang

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57675

_coding style issues_


WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#173: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:65:
+	 */                                                                 \

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#196: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:88:
+#define __ATOMIC128_LDX_OP(ldx_op_name, op_string)                          \
+static inline rte_int128_t                                                  \
+ldx_op_name(const rte_int128_t *src)                                        \
+{                                                                           \
+	rte_int128_t ret;                                                   \
+	asm volatile(                                                       \
+			op_string " %0, %1, %2"                             \
+			: "=&r" (ret.val[0]),                               \
+			  "=&r" (ret.val[1])                                \
+			: "Q" (src->val[0])                                 \
+			: "memory");                                        \
+	return ret;                                                         \
+}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#213: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:105:
+#define __ATOMIC128_STX_OP(stx_op_name, op_string)                          \
+static inline uint32_t                                                      \
+stx_op_name(rte_int128_t *dst, const rte_int128_t src)                      \
+{                                                                           \
+	uint32_t ret;                                                       \
+	asm volatile(                                                       \
+			op_string " %w0, %1, %2, %3"                        \
+			: "=&r" (ret)                                       \
+			: "r" (src.val[0]),                                 \
+			  "r" (src.val[1]),                                 \
+			  "Q" (dst->val[0])                                 \
+			: "memory");                                        \
+	/* Return 0 on success, 1 on failure */                             \
+	return ret;                                                         \
+}

total: 0 errors, 3 warnings, 260 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1565771263-27353-1-git-send-email-phil.yang@arm.com>
2019-08-14  8:30 ` [dpdk-test-report] |WARNING| pw57675 [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare exchange checkpatch

automatic DPDK test reports

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ http://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/ public-inbox