automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Sachin Saxena <sachin.saxena@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw58025 [PATCH v1 30/30] net/dpaa2: add soft parser driver
Date: Tue, 27 Aug 2019 09:15:50 +0200 (CEST)	[thread overview]
Message-ID: <20190827071550.0922D1C028@dpdk.org> (raw)
In-Reply-To: <20190827070730.11206-31-sachin.saxena@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/58025

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pr' - possible side-effects?
#260: FILE: drivers/net/dpaa2/dpaa2_sparser.c:148:
+#define SWAP_WORD(pr)						\
+do {								\
+	for (int i = 0; i < 4 ; i++) {				\
+		pr[i] = pr[i] ^ pr[6 - i + 1];			\
+		pr[6 - i + 1] = pr[6 - i + 1] ^ pr[i];		\
+		pr[i] = pr[i] ^ pr[6 - i + 1];			\
+	}							\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'priv' - possible side-effects?
#407: FILE: drivers/net/dpaa2/dpaa2_sparser.h:20:
+#define WRIOP_SS_INITIALIZER(priv)				\
+do {								\
+	/* Base offset of parse profile memory in WRIOP */	\
+	(priv)->ss_offset = 0x20;				\
+	(priv)->ss_iova	= (size_t)NULL;			\
+	(priv)->ss_param_iova = (size_t)NULL;			\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mask' - possible side-effects?
#586: FILE: drivers/net/dpaa2/dpaa2_sparser.h:199:
+#define IS_ONE_BIT_FIELD(_mask)                 \
+(!((_mask) & ((_mask) - 1)) || (_mask == 1))

total: 0 errors, 0 warnings, 3 checks, 541 lines checked

           reply	other threads:[~2019-08-27  7:15 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190827070730.11206-31-sachin.saxena@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827071550.0922D1C028@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=sachin.saxena@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).