From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0A3BA2E1B
	for <public@inbox.dpdk.org>; Wed,  4 Sep 2019 08:37:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0153D1ED1E;
	Wed,  4 Sep 2019 08:37:37 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id E24751ED09; Wed,  4 Sep 2019 08:37:35 +0200 (CEST)
In-Reply-To: <20190903221522.151382-3-ying.a.wang@intel.com>
References: <20190903221522.151382-3-ying.a.wang@intel.com>
To: test-report@dpdk.org
Cc: Ying Wang <ying.a.wang@intel.com>
Message-Id: <20190904063735.E24751ED09@dpdk.org>
Date: Wed,  4 Sep 2019 08:37:35 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw58546 [PATCH 2/4] net/ice: rework
	for generic flow enabling
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/58546

_coding style issues_


WARNING:TYPO_SPELLING: 'swith' may be misspelled - perhaps 'switch'?
#152: FILE: drivers/net/ice/ice_generic_flow.c:22:
+ * Non-pipeline mode, fdir and swith both used as distributor,

CHECK:BRACES: braces {} should be used on all arms of this statement
#272: FILE: drivers/net/ice/ice_generic_flow.c:151:
+	if (ad->devargs.pipeline_mode_support)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#274: FILE: drivers/net/ice/ice_generic_flow.c:153:
+	else {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#276: FILE: drivers/net/ice/ice_generic_flow.c:155:
+		if (parser->engine->type == ICE_FLOW_ENGINE_SWITCH
+			|| parser->engine->type == ICE_FLOW_ENGINE_HASH)

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#314: FILE: drivers/net/ice/ice_generic_flow.c:193:
+
+}

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#338: FILE: drivers/net/ice/ice_generic_flow.c:217:
+		if (0 == attr->priority)

CHECK:BRACES: Unbalanced braces around else statement
#1002: FILE: drivers/net/ice/ice_generic_flow.c:533:
+	} else

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1853: FILE: drivers/net/ice/ice_generic_flow.h:177:
+ice_search_pattern_match_item(

total: 0 errors, 2 warnings, 6 checks, 1811 lines checked