From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Marcin Zapolski <marcinx.a.zapolski@intel.com>
Subject: [dpdk-test-report] |WARNING| pw58874 [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API
Date: Fri, 6 Sep 2019 15:22:33 +0200 (CEST) [thread overview]
Message-ID: <20190906132233.276001F420@dpdk.org> (raw)
In-Reply-To: <20190906131813.1343-2-marcinx.a.zapolski@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/58874
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#350: FILE: lib/librte_ethdev/rte_ethdev.h:1299:
+#define RTE_ETH_VALID_RX_QUEUEID_OR_ERR_RET(port_id, queue_id, retval) do { \
+ if (!rte_eth_dev_is_valid_rx_queue_id(port_id, queue_id)) { \
+ RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u
", queue_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#357: FILE: lib/librte_ethdev/rte_ethdev.h:1306:
+#define RTE_ETH_VALID_TX_QUEUEID_OR_ERR_RET(port_id, queue_id, retval) do { \
+ if (!rte_eth_dev_is_valid_tx_queue_id(port_id, queue_id)) { \
+ RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u
", queue_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1309: FILE: lib/librte_ethdev/rte_ethdev_driver.h:80:
+ struct rte_eth_xstat *stats, unsigned n);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1322: FILE: lib/librte_ethdev/rte_ethdev_driver.h:93:
+ struct rte_eth_xstat_name *xstats_names, unsigned size);
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1627: FILE: lib/librte_ethdev/rte_ethdev_driver.h:398:
+ eth_xstats_reset_t xstats_reset; /**< Reset extended device statistics. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1644: FILE: lib/librte_ethdev/rte_ethdev_driver.h:415:
+ vlan_pvid_set_t vlan_pvid_set; /**< Set port based TX VLAN insertion. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1659: FILE: lib/librte_ethdev/rte_ethdev_driver.h:430:
+ eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1660: FILE: lib/librte_ethdev/rte_ethdev_driver.h:431:
+ eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1670: FILE: lib/librte_ethdev/rte_ethdev_driver.h:441:
+ priority_flow_ctrl_set_t priority_flow_ctrl_set; /**< Setup priority flow control. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1673: FILE: lib/librte_ethdev/rte_ethdev_driver.h:444:
+ eth_uc_all_hash_table_set_t uc_all_hash_table_set; /**< Set Unicast hash bitmap. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#1688: FILE: lib/librte_ethdev/rte_ethdev_driver.h:459:
+ rss_hash_conf_get_t rss_hash_conf_get; /** Get current RSS hash configuration. */
total: 0 errors, 11 warnings, 1790 lines checked
ERROR: symbol rte_eth_dev_functions is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_eth_dev_is_valid_rx_queue_id is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_eth_dev_is_valid_tx_queue_id is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_eth_rx_descriptor_done is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_eth_rx_descriptor_status is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_eth_rx_queue_count is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_eth_tx_descriptor_status is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map
parent reply other threads:[~2019-09-06 13:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190906131813.1343-2-marcinx.a.zapolski@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906132233.276001F420@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=marcinx.a.zapolski@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).