From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70B0BA2EDB for ; Fri, 6 Sep 2019 15:22:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EAF21F3FB; Fri, 6 Sep 2019 15:22:34 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 276001F420; Fri, 6 Sep 2019 15:22:33 +0200 (CEST) In-Reply-To: <20190906131813.1343-2-marcinx.a.zapolski@intel.com> References: <20190906131813.1343-2-marcinx.a.zapolski@intel.com> To: test-report@dpdk.org Cc: Marcin Zapolski Message-Id: <20190906132233.276001F420@dpdk.org> Date: Fri, 6 Sep 2019 15:22:33 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw58874 [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/58874 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #350: FILE: lib/librte_ethdev/rte_ethdev.h:1299: +#define RTE_ETH_VALID_RX_QUEUEID_OR_ERR_RET(port_id, queue_id, retval) do { \ + if (!rte_eth_dev_is_valid_rx_queue_id(port_id, queue_id)) { \ + RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u ", queue_id); \ + return retval; \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #357: FILE: lib/librte_ethdev/rte_ethdev.h:1306: +#define RTE_ETH_VALID_TX_QUEUEID_OR_ERR_RET(port_id, queue_id, retval) do { \ + if (!rte_eth_dev_is_valid_tx_queue_id(port_id, queue_id)) { \ + RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u ", queue_id); \ + return retval; \ + } \ +} while (0) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1309: FILE: lib/librte_ethdev/rte_ethdev_driver.h:80: + struct rte_eth_xstat *stats, unsigned n); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1322: FILE: lib/librte_ethdev/rte_ethdev_driver.h:93: + struct rte_eth_xstat_name *xstats_names, unsigned size); WARNING:LONG_LINE_COMMENT: line over 90 characters #1627: FILE: lib/librte_ethdev/rte_ethdev_driver.h:398: + eth_xstats_reset_t xstats_reset; /**< Reset extended device statistics. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #1644: FILE: lib/librte_ethdev/rte_ethdev_driver.h:415: + vlan_pvid_set_t vlan_pvid_set; /**< Set port based TX VLAN insertion. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #1659: FILE: lib/librte_ethdev/rte_ethdev_driver.h:430: + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #1660: FILE: lib/librte_ethdev/rte_ethdev_driver.h:431: + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #1670: FILE: lib/librte_ethdev/rte_ethdev_driver.h:441: + priority_flow_ctrl_set_t priority_flow_ctrl_set; /**< Setup priority flow control. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #1673: FILE: lib/librte_ethdev/rte_ethdev_driver.h:444: + eth_uc_all_hash_table_set_t uc_all_hash_table_set; /**< Set Unicast hash bitmap. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #1688: FILE: lib/librte_ethdev/rte_ethdev_driver.h:459: + rss_hash_conf_get_t rss_hash_conf_get; /** Get current RSS hash configuration. */ total: 0 errors, 11 warnings, 1790 lines checked ERROR: symbol rte_eth_dev_functions is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_eth_dev_is_valid_rx_queue_id is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_eth_dev_is_valid_tx_queue_id is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_eth_rx_descriptor_done is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_eth_rx_descriptor_status is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_eth_rx_queue_count is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_eth_tx_descriptor_status is added in the DPDK_19.11 section, but is expected to be added in the EXPERIMENTAL section of the version map