automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw59004 [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status
Date: Mon,  9 Sep 2019 14:00:37 +0200 (CEST)	[thread overview]
Message-ID: <20190909120037.97DA61ECE9@dpdk.org> (raw)
In-Reply-To: <1568030331-16526-5-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59004

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1299: FILE: drivers/net/i40e/i40e_vf_representor.c:282:
+	return rte_pmd_i40e_set_vf_unicast_promisc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1311: FILE: drivers/net/i40e/i40e_vf_representor.c:292:
+	return rte_pmd_i40e_set_vf_unicast_promisc(

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#2073: FILE: drivers/net/netvsc/hn_vf.c:366:
+#define VF_ETHDEV_FUNC_RET_STATUS(dev, func)			\
+	{							\
+		struct hn_data *hv = (dev)->data->dev_private;	\
+		struct rte_eth_dev *vf_dev;			\
+		int ret = 0;					\
+		rte_spinlock_lock(&hv->vf_lock);		\
+		vf_dev = hn_get_vf_dev(hv);			\
+		if (vf_dev)					\
+			ret = func(vf_dev->data->port_id);	\
+		rte_spinlock_unlock(&hv->vf_lock);		\
+		return ret;					\
+	}

total: 0 errors, 1 warnings, 2301 lines checked

           reply	other threads:[~2019-09-09 12:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1568030331-16526-5-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190909120037.97DA61ECE9@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).