From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Hyong Youb Kim <hyonkim@cisco.com>
Subject: [dpdk-test-report] |WARNING| pw59094 [PATCH 2/2] net/enic: add flow implementation based on Flow Manager API
Date: Tue, 10 Sep 2019 12:01:16 +0200 (CEST) [thread overview]
Message-ID: <20190910100116.4EAAF1EE58@dpdk.org> (raw)
In-Reply-To: <20190910095937.9731-3-hyonkim@cisco.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59094
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#298: FILE: drivers/net/enic/base/vnic_flowman.h:33:
+#define FKM_BITS \
+ FBIT(FKM_QTAG) \
+ FBIT(FKM_CMD) \
+ FBIT(FKM_IPV4) \
+ FBIT(FKM_IPV6) \
+ FBIT(FKM_ROCE) \
+ FBIT(FKM_UDP) \
+ FBIT(FKM_TCP) \
+ FBIT(FKM_TCPORUDP) \
+ FBIT(FKM_IPFRAG) \
+ FBIT(FKM_NVGRE) \
+ FBIT(FKM_VXLAN) \
+ FBIT(FKM_GENEVE) \
+ FBIT(FKM_NSH) \
+ FBIT(FKM_ROCEV2) \
+ FBIT(FKM_VLAN_PRES) \
+ FBIT(FKM_IPOK) \
+ FBIT(FKM_L4OK) \
+ FBIT(FKM_ROCEOK) \
+ FBIT(FKM_FCSOK) \
+ FBIT(FKM_EG_SPAN) \
+ FBIT(FKM_IG_SPAN) \
+ FBIT(FKM_EG_HAIRPINNED)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#331: FILE: drivers/net/enic/base/vnic_flowman.h:66:
+#define FKH_BITS \
+ FBIT(FKH_ETHER) \
+ FBIT(FKH_QTAG) \
+ FBIT(FKH_L2RAW) \
+ FBIT(FKH_IPV4) \
+ FBIT(FKH_IPV6) \
+ FBIT(FKH_L3RAW) \
+ FBIT(FKH_UDP) \
+ FBIT(FKH_TCP) \
+ FBIT(FKH_ICMP) \
+ FBIT(FKH_VXLAN) \
+ FBIT(FKH_L4RAW)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/net/enic/base/vnic_flowman.h:90:
+#define FBIT(X) X = (1 << X##_BIT),
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#1405: FILE: drivers/net/enic/enic_fm_flow.c:674:
+ ENICPMD_LOG(DEBUG, "allocated exact match table: handle=0x%" PRIx64,
total: 3 errors, 0 warnings, 1 checks, 3141 lines checked
parent reply other threads:[~2019-09-10 10:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190910095937.9731-3-hyonkim@cisco.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910100116.4EAAF1EE58@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).