* [dpdk-test-report] |WARNING| pw59903 [PATCH v3 21/22] net/hns3: add reset related process for hns3 PMD driver
[not found] <1569506528-60464-22-git-send-email-xavier.huwei@huawei.com>
@ 2019-09-27 12:07 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-09-27 12:07 UTC (permalink / raw)
To: test-report; +Cc: Wei Hu (Xavier)
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59903
_coding style issues_
CHECK:BRACES: braces {} should be used on all arms of this statement
#199: FILE: drivers/net/hns3/hns3_ethdev.c:215:
+ if (event_cause == HNS3_VECTOR0_EVENT_ERR) {
[...]
+ } else if (event_cause == HNS3_VECTOR0_EVENT_RST)
[...]
+ else
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#296: FILE: drivers/net/hns3/hns3_ethdev.c:3786:
+ if (!hns3_is_reset_pending(hns)) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#299: FILE: drivers/net/hns3/hns3_ethdev.c:3789:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#320: FILE: drivers/net/hns3/hns3_ethdev.c:4056:
+ if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#323: FILE: drivers/net/hns3/hns3_ethdev.c:4059:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#468: FILE: drivers/net/hns3/hns3_ethdev.c:4396:
+ if (wait_data->result == HNS3_WAIT_SUCCESS)
[...]
+ else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
[...]
+ } else if (wait_data->result == HNS3_WAIT_REQUEST)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#635: FILE: drivers/net/hns3/hns3_ethdev.c:4563:
+ if (hns->hw.adapter_state == HNS3_NIC_STARTED ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#639: FILE: drivers/net/hns3/hns3_ethdev.c:4567:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#699: FILE: drivers/net/hns3/hns3_ethdev.c:4627:
+ if (hns->hw.adapter_state == HNS3_NIC_STARTED) {
[...]
+ } else if (hw->adapter_state == HNS3_NIC_STOPPING)
[...]
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#758: FILE: drivers/net/hns3/hns3_ethdev.c:4686:
+ hns3_err(hw, "%d handle long time delta %" PRIx64
CHECK:BRACES: braces {} should be used on all arms of this statement
#1050: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1126:
+ if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1053: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1129:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1151: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1300:
+ if (wait_data->result == HNS3_WAIT_SUCCESS)
[...]
+ else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
[...]
+ } else if (wait_data->result == HNS3_WAIT_REQUEST)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1200: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1349:
+ if (hw->adapter_state == HNS3_NIC_STARTED ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1204: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1353:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1250: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1399:
+ if (hw->adapter_state == HNS3_NIC_STARTED) {
[...]
+ } else if (hw->adapter_state == HNS3_NIC_STOPPING)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1513: FILE: drivers/net/hns3/hns3_intr.c:732:
+ if (data->check_completion) {
[...]
+ } else
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1519: FILE: drivers/net/hns3/hns3_intr.c:738:
+ if (msec > data->end_ms || is_reset_pending(hns) ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1523: FILE: drivers/net/hns3/hns3_intr.c:742:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#1525: FILE: drivers/net/hns3/hns3_intr.c:744:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1532: FILE: drivers/net/hns3/hns3_intr.c:751:
+ if (done)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1534: FILE: drivers/net/hns3/hns3_intr.c:753:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#1561: FILE: drivers/net/hns3/hns3_intr.c:780:
+ if (hw->reset.wait_data->result == HNS3_WAIT_UNKNOWN) {
[...]
+ } else if (hw->reset.wait_data->result == HNS3_WAIT_REQUEST)
[...]
total: 0 errors, 0 warnings, 23 checks, 1926 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-27 12:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1569506528-60464-22-git-send-email-xavier.huwei@huawei.com>
2019-09-27 12:07 ` [dpdk-test-report] |WARNING| pw59903 [PATCH v3 21/22] net/hns3: add reset related process for hns3 PMD driver checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).