From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw60117 [PATCH 4/9] net/qede/base: rename HSI datatypes and funcs
Date: Mon, 30 Sep 2019 04:50:31 +0200 (CEST) [thread overview]
Message-ID: <20190930025031.BDDE258C4@dpdk.org> (raw)
In-Reply-To: <20190930024921.21818-5-rmody@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60117
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'map' - possible side-effects?
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+ rl_valid, rl_id, voq, wrr) \
+ do { \
+ OSAL_MEMSET(&map, 0, sizeof(map)); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+ STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'map' may be better as '(map)' to avoid precedence issues
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+ rl_valid, rl_id, voq, wrr) \
+ do { \
+ OSAL_MEMSET(&map, 0, sizeof(map)); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+ STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pq_id' may be better as '(pq_id)' to avoid precedence issues
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+ rl_valid, rl_id, voq, wrr) \
+ do { \
+ OSAL_MEMSET(&map, 0, sizeof(map)); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+ SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+ STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
} while (0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#2959: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:165:
+ do { \
+ OSAL_MEMSET(&map, 0, sizeof(map)); \
total: 0 errors, 1 warnings, 3 checks, 3176 lines checked
parent reply other threads:[~2019-09-30 2:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190930024921.21818-5-rmody@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930025031.BDDE258C4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rmody@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).