From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9DFD3A2EFD
	for <public@inbox.dpdk.org>; Mon, 30 Sep 2019 04:50:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 455FB1B203;
	Mon, 30 Sep 2019 04:50:34 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id BDDE258C4; Mon, 30 Sep 2019 04:50:31 +0200 (CEST)
In-Reply-To: <20190930024921.21818-5-rmody@marvell.com>
References: <20190930024921.21818-5-rmody@marvell.com>
To: test-report@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>
Message-Id: <20190930025031.BDDE258C4@dpdk.org>
Date: Mon, 30 Sep 2019 04:50:31 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw60117 [PATCH 4/9] net/qede/base:
	rename HSI datatypes and funcs
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60117

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'map' - possible side-effects?
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+			   rl_valid, rl_id, voq, wrr) \
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+	STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
 	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'map' may be better as '(map)' to avoid precedence issues
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+			   rl_valid, rl_id, voq, wrr) \
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+	STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
 	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pq_id' may be better as '(pq_id)' to avoid precedence issues
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+			   rl_valid, rl_id, voq, wrr) \
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+	STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
 	} while (0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#2959: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:165:
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \

total: 0 errors, 1 warnings, 3 checks, 3176 lines checked