From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: [dpdk-test-report] |WARNING| pw60717 [PATCH v4 5/5] app: add test-sad application
Date: Tue, 8 Oct 2019 18:56:38 +0200 (CEST) [thread overview]
Message-ID: <20191008165638.ED0A01E53E@dpdk.org> (raw)
In-Reply-To: <b9a036a847a4f91b96d500acc10b2330e25da358.1570553345.git.vladimir.medvedkin@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60717
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#113: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end_fld; \
+ errno = 0; \
+ val = strtoul((in), &end_fld, (base)); \
+ if (errno != 0 || end_fld[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end_fld + 1; \
+} while (0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#321: FILE: app/test-sad/main.c:232:
+ unsigned i, j, rnd;
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#612: FILE: app/test-sad/main.c:523:
+ printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf
",
total: 0 errors, 3 warnings, 684 lines checked
parent reply other threads:[~2019-10-08 16:56 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <b9a036a847a4f91b96d500acc10b2330e25da358.1570553345.git.vladimir.medvedkin@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008165638.ED0A01E53E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).