* [dpdk-test-report] |WARNING| pw60915 [PATCH v5 5/5] app: add test-sad application
[not found] <0448c97953f70a0d3e781ac593456916034d1685.1570725872.git.vladimir.medvedkin@intel.com>
@ 2019-10-10 16:50 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-10-10 16:50 UTC (permalink / raw)
To: test-report; +Cc: Vladimir Medvedkin
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60915
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#113: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end_fld; \
+ errno = 0; \
+ val = strtoul((in), &end_fld, (base)); \
+ if (errno != 0 || end_fld[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end_fld + 1; \
+} while (0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#321: FILE: app/test-sad/main.c:232:
+ unsigned i, j, rnd;
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#612: FILE: app/test-sad/main.c:523:
+ printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf
",
total: 0 errors, 3 warnings, 684 lines checked
^ permalink raw reply [flat|nested] only message in thread