From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 957B5A04F1 for ; Fri, 13 Dec 2019 15:37:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C7AA1BFAE; Fri, 13 Dec 2019 15:37:25 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 2A5181BFBA; Fri, 13 Dec 2019 15:37:25 +0100 (CET) In-Reply-To: <20191213233554.90866-1-chenmin.sun@intel.com> References: <20191213233554.90866-1-chenmin.sun@intel.com> To: test-report@dpdk.org Cc: chenmin.sun@intel.com Message-Id: <20191213143725.2A5181BFBA@dpdk.org> Date: Fri, 13 Dec 2019 15:37:25 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw63851 [FDIO] dpdk: add devargs support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/63851 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #74: FILE: src/plugins/dpdk/device/dpdk.h:339: + u8 *devargs;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: src/plugins/dpdk/device/format.c:567: + if (di.device->devargs && di.device->devargs->args)$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (2, 4) #87: FILE: src/plugins/dpdk/device/format.c:567: + if (di.device->devargs && di.device->devargs->args) + s = format (s, "%UDevargs: %s ", WARNING:LEADING_SPACE: please, no spaces at the start of a line #88: FILE: src/plugins/dpdk/device/format.c:568: + s = format (s, "%UDevargs: %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: src/plugins/dpdk/device/init.c:1121: + else if (unformat (input, "devargs %s", &devconf->devargs))$ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #101: FILE: src/plugins/dpdk/device/init.c:1121: + else if (unformat (input, "devargs %s", &devconf->devargs)) ERROR:OPEN_BRACE: that open brace { should be on the previous line #114: FILE: src/plugins/dpdk/device/init.c:1437: if (num_whitelisted > 0 && devconf->is_blacklisted == 0) + { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 10) #114: FILE: src/plugins/dpdk/device/init.c:1437: if (num_whitelisted > 0 && devconf->is_blacklisted == 0) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #121: FILE: src/plugins/dpdk/device/init.c:1438: + {$ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #123: FILE: src/plugins/dpdk/device/init.c:1440: + vec_add1 (conf->eal_init_args, tmp); WARNING:TABSTOP: Statements should start on a tabstop #124: FILE: src/plugins/dpdk/device/init.c:1441: + if (devconf->devargs) ERROR:OPEN_BRACE: that open brace { should be on the previous line #124: FILE: src/plugins/dpdk/device/init.c:1441: + if (devconf->devargs) + { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (10, 12) #124: FILE: src/plugins/dpdk/device/init.c:1441: + if (devconf->devargs) + { WARNING:TABSTOP: Statements should start on a tabstop #125: FILE: src/plugins/dpdk/device/init.c:1442: + { WARNING:LONG_LINE: line over 90 characters #126: FILE: src/plugins/dpdk/device/init.c:1443: + tmp = format (0, "%U,%s", format_vlib_pci_addr, &devconf->pci_addr, devconf->devargs, 0); WARNING:TABSTOP: Statements should start on a tabstop #127: FILE: src/plugins/dpdk/device/init.c:1444: + } WARNING:TABSTOP: Statements should start on a tabstop #128: FILE: src/plugins/dpdk/device/init.c:1445: + else ERROR:OPEN_BRACE: that open brace { should be on the previous line #128: FILE: src/plugins/dpdk/device/init.c:1445: + else + { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (10, 12) #128: FILE: src/plugins/dpdk/device/init.c:1445: + else + { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #128: FILE: src/plugins/dpdk/device/init.c:1445: + } + else WARNING:TABSTOP: Statements should start on a tabstop #129: FILE: src/plugins/dpdk/device/init.c:1446: + { WARNING:TABSTOP: Statements should start on a tabstop #131: FILE: src/plugins/dpdk/device/init.c:1448: + } WARNING:SPACING: space prohibited between function name and open parenthesis '(' #132: FILE: src/plugins/dpdk/device/init.c:1449: + vec_add1 (conf->eal_init_args, tmp); WARNING:LEADING_SPACE: please, no spaces at the start of a line #133: FILE: src/plugins/dpdk/device/init.c:1450: + }$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #134: FILE: src/plugins/dpdk/device/init.c:1451: else if (num_whitelisted == 0 && devconf->is_blacklisted != 0) + { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 10) #134: FILE: src/plugins/dpdk/device/init.c:1451: else if (num_whitelisted == 0 && devconf->is_blacklisted != 0) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #141: FILE: src/plugins/dpdk/device/init.c:1452: + {$ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #143: FILE: src/plugins/dpdk/device/init.c:1454: + vec_add1 (conf->eal_init_args, tmp); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #145: FILE: src/plugins/dpdk/device/init.c:1456: + vec_add1 (conf->eal_init_args, tmp); WARNING:LEADING_SPACE: please, no spaces at the start of a line #146: FILE: src/plugins/dpdk/device/init.c:1457: + }$ total: 5 errors, 25 warnings, 79 lines checked