From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 620DDA046B for ; Thu, 9 Jan 2020 16:40:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F97B1DE1A; Thu, 9 Jan 2020 16:40:57 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 602A11DE1A; Thu, 9 Jan 2020 16:40:56 +0100 (CET) In-Reply-To: <20200109153912.5263-1-mk@semihalf.com> References: <20200109153912.5263-1-mk@semihalf.com> To: test-report@dpdk.org Cc: Michal Krawczyk Message-Id: <20200109154056.602A11DE1A@dpdk.org> Date: Thu, 9 Jan 2020 16:40:56 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw64378 [PATCH v2 1/2] net/ena: upgrade HAL for new HW features X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/64378 _coding style issues_ WARNING:LONG_LINE: line over 90 characters #370: FILE: drivers/net/ena/base/ena_com.c:750: + comp_ctx->cmd_opcode, admin_queue->auto_polling ? "ON" : "OFF"); WARNING:LONG_LINE_COMMENT: line over 90 characters #384: FILE: drivers/net/ena/base/ena_com.c:760: + * and autopolling mode is enabled. Continuing normal execution in such case WARNING:LONG_LINE: line over 90 characters #411: FILE: drivers/net/ena/base/ena_com.c:924: + (io_sq->llq_info.desc_list_entry_size * ENA_COM_BOUNCE_BUFFER_CNTRL_CNT)); ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #441: FILE: drivers/net/ena/base/ena_com.c:1685: +bool ena_com_get_admin_polling_mode(struct ena_com_dev * ena_dev) CHECK:CAMELCASE: Avoid CamelCase: #474: FILE: drivers/net/ena/base/ena_com.c:2127: + ena_trc_dbg("AENQ! Group[%x] Syndrom[%x] timestamp: [%"PRIu64"] ", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #474: FILE: drivers/net/ena/base/ena_com.c:2127: + ena_trc_dbg("AENQ! Group[%x] Syndrom[%x] timestamp: [%"PRIu64"] ", WARNING:LONG_LINE: line over 90 characters #512: FILE: drivers/net/ena/base/ena_com.c:2924: + (sizeof(struct ena_intr_moder_entry) * ENA_INTR_MAX_NUM_OF_LEVELS)); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around ena_dev->llq_info #532: FILE: drivers/net/ena/base/ena_com.c:3069: + struct ena_com_llq_info *llq_info = &(ena_dev->llq_info);; WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #532: FILE: drivers/net/ena/base/ena_com.c:3069: + struct ena_com_llq_info *llq_info = &(ena_dev->llq_info);; WARNING:LONG_LINE: line over 90 characters #706: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1552: +static inline uint32_t get_ena_admin_host_info_mutable_rss_table_size(const struct ena_admin_host_info *p) WARNING:LONG_LINE: line over 90 characters #708: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1554: + return p->driver_supported_features & ENA_ADMIN_HOST_INFO_MUTABLE_RSS_TABLE_SIZE_MASK; WARNING:LONG_LINE: line over 90 characters #711: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1557: +static inline void set_ena_admin_host_info_mutable_rss_table_size(struct ena_admin_host_info *p, uint32_t val) WARNING:LONG_LINE: line over 90 characters #713: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1559: + p->driver_supported_features |= val & ENA_ADMIN_HOST_INFO_MUTABLE_RSS_TABLE_SIZE_MASK; WARNING:LONG_LINE: line over 90 characters #716: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1562: +static inline uint32_t get_ena_admin_host_info_rx_offset(const struct ena_admin_host_info *p) WARNING:LONG_LINE: line over 90 characters #718: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1564: + return (p->driver_supported_features & ENA_ADMIN_HOST_INFO_RX_OFFSET_MASK) >> ENA_ADMIN_HOST_INFO_RX_OFFSET_SHIFT; WARNING:LONG_LINE: line over 90 characters #721: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1567: +static inline void set_ena_admin_host_info_rx_offset(struct ena_admin_host_info *p, uint32_t val) WARNING:LONG_LINE: line over 90 characters #723: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1569: + p->driver_supported_features |= (val << ENA_ADMIN_HOST_INFO_RX_OFFSET_SHIFT) & ENA_ADMIN_HOST_INFO_RX_OFFSET_MASK; WARNING:LONG_LINE: line over 90 characters #726: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1572: +static inline uint32_t get_ena_admin_host_info_interrupt_moderation(const struct ena_admin_host_info *p) WARNING:LONG_LINE: line over 90 characters #728: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1574: + return (p->driver_supported_features & ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_MASK) >> ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_SHIFT; WARNING:LONG_LINE: line over 90 characters #731: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1577: +static inline void set_ena_admin_host_info_interrupt_moderation(struct ena_admin_host_info *p, uint32_t val) WARNING:LONG_LINE: line over 90 characters #733: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1579: + p->driver_supported_features |= (val << ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_SHIFT) & ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_MASK; WARNING:LONG_LINE: line over 90 characters #736: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1582: +static inline uint32_t get_ena_admin_host_info_map_rx_buf_bidirectional(const struct ena_admin_host_info *p) WARNING:LONG_LINE: line over 90 characters #738: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1584: + return (p->driver_supported_features & ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_MASK) >> ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_SHIFT; WARNING:LONG_LINE: line over 90 characters #741: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1587: +static inline void set_ena_admin_host_info_map_rx_buf_bidirectional(struct ena_admin_host_info *p, uint32_t val) WARNING:LONG_LINE: line over 90 characters #743: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1589: + p->driver_supported_features |= (val << ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_SHIFT) & ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_MASK; CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #845: FILE: drivers/net/ena/base/ena_eth_com.c:8: +static struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc( WARNING:LONG_LINE: line over 90 characters #955: FILE: drivers/net/ena/base/ena_eth_com.c:191: + if (unlikely(llq_info->desc_stride_ctrl == ENA_ADMIN_SINGLE_DESC_PER_ENTRY)) WARNING:LONG_LINE: line over 90 characters #1102: FILE: drivers/net/ena/base/ena_eth_com.c:527: + } while ((++i < nb_hw_desc) && (cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i))); total: 1 errors, 23 warnings, 4 checks, 1092 lines checked