From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EF50BA052A
	for <public@inbox.dpdk.org>; Mon, 20 Jan 2020 15:19:44 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E2DC13576;
	Mon, 20 Jan 2020 15:19:44 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 532FC1BE3D; Mon, 20 Jan 2020 15:19:43 +0100 (CET)
In-Reply-To: <20200120141603.18719-3-i.dyukov@samsung.com>
References: <20200120141603.18719-3-i.dyukov@samsung.com>
To: test-report@dpdk.org
Cc: Ivan Dyukov <i.dyukov@samsung.com>
Message-Id: <20200120141943.532FC1BE3D@dpdk.org>
Date: Mon, 20 Jan 2020 15:19:43 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw64933 [PATCH 2/2] net/virtio: add
	link speed devarg
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/64933

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#134: FILE: drivers/net/virtio/virtio_ethdev.c:49:
+static int virtio_dev_devargs_parse(

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#169: FILE: drivers/net/virtio/virtio_ethdev.c:1969:
+static const char *valid_args[] = {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#181: FILE: drivers/net/virtio/virtio_ethdev.c:1986:
+static uint32_t
+virtio_dev_speed_capa_get(uint32_t link_speed) {

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#183: FILE: drivers/net/virtio/virtio_ethdev.c:1988:
+	switch (link_speed) {
+		case ETH_SPEED_NUM_10G:
[...]
+		case ETH_SPEED_NUM_20G:
[...]
+		case ETH_SPEED_NUM_25G:
[...]
+		case ETH_SPEED_NUM_40G:
[...]
+		case ETH_SPEED_NUM_50G:
[...]
+		case ETH_SPEED_NUM_56G:
[...]
+		case ETH_SPEED_NUM_100G:
[...]
+		default:

total: 2 errors, 1 warnings, 1 checks, 168 lines checked