* [dpdk-test-report] |WARNING| pw65131 [PATCH v2] net/e1000: update UPDATE_VF_STAT to handle rollover
[not found] <20200126172548.23327-1-dharton@cisco.com>
@ 2020-01-26 17:26 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-01-26 17:26 UTC (permalink / raw)
To: test-report; +Cc: David Harton
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65131
_coding style issues_
ERROR:BAD_SIGN_OFF: Unrecognized email address: 'intel.com'
#69:
Cc: intel.com
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects?
#89: FILE: drivers/net/e1000/igb_ethdev.c:264:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ u32 latest = E1000_READ_REG(hw, reg); \
+ if (latest >= last) \
+ cur += (latest - last); \
+ else \
+ cur += ((latest + ((uint64_t)1 << 32)) - last); \
+ cur &= UINT_MAX; \
+ last = latest; \
}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues
#89: FILE: drivers/net/e1000/igb_ethdev.c:264:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ u32 latest = E1000_READ_REG(hw, reg); \
+ if (latest >= last) \
+ cur += (latest - last); \
+ else \
+ cur += ((latest + ((uint64_t)1 << 32)) - last); \
+ cur &= UINT_MAX; \
+ last = latest; \
}
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cur' - possible side-effects?
#89: FILE: drivers/net/e1000/igb_ethdev.c:264:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ u32 latest = E1000_READ_REG(hw, reg); \
+ if (latest >= last) \
+ cur += (latest - last); \
+ else \
+ cur += ((latest + ((uint64_t)1 << 32)) - last); \
+ cur &= UINT_MAX; \
+ last = latest; \
}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues
#89: FILE: drivers/net/e1000/igb_ethdev.c:264:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ u32 latest = E1000_READ_REG(hw, reg); \
+ if (latest >= last) \
+ cur += (latest - last); \
+ else \
+ cur += ((latest + ((uint64_t)1 << 32)) - last); \
+ cur &= UINT_MAX; \
+ last = latest; \
}
total: 1 errors, 0 warnings, 4 checks, 20 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-26 17:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200126172548.23327-1-dharton@cisco.com>
2020-01-26 17:26 ` [dpdk-test-report] |WARNING| pw65131 [PATCH v2] net/e1000: update UPDATE_VF_STAT to handle rollover checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).