From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Matan Azrad <matan@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw65229 [PATCH v2 02/25] drivers: introduce mlx5 common library
Date: Tue, 28 Jan 2020 12:07:46 +0100 (CET) [thread overview]
Message-ID: <20200128110746.A7C861C24F@dpdk.org> (raw)
In-Reply-To: <1580205965-21492-3-git-send-email-matan@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65229
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#769: FILE: drivers/common/mlx5/mlx5_common.h:18:
+#define PMD_DRV_LOG_OPAREN (
ERROR:SPACING: space prohibited before that close parenthesis ')'
#770: FILE: drivers/common/mlx5/mlx5_common.h:19:
+#define PMD_DRV_LOG_CPAREN )
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#770: FILE: drivers/common/mlx5/mlx5_common.h:19:
+#define PMD_DRV_LOG_CPAREN )
ERROR:SPACING: space prohibited before that ',' (ctx:WxE)
#771: FILE: drivers/common/mlx5/mlx5_common.h:20:
+#define PMD_DRV_LOG_COMMA ,
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#771: FILE: drivers/common/mlx5/mlx5_common.h:20:
+#define PMD_DRV_LOG_COMMA ,
ERROR:SPACING: space required after that ',' (ctx:VxB)
#789: FILE: drivers/common/mlx5/mlx5_common.h:38:
+ RTE_FMT_HEAD(__VA_ARGS__,), \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#790: FILE: drivers/common/mlx5/mlx5_common.h:39:
+ RTE_FMT_TAIL(__VA_ARGS__,)))
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1826: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:956:
+ void *tx_domain __rte_unused, FILE *file __rte_unused)
^
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2283: FILE: drivers/common/mlx5/mlx5_glue.c:194:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2342: FILE: drivers/common/mlx5/mlx5_glue.c:253:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2357: FILE: drivers/common/mlx5/mlx5_glue.c:268:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2370: FILE: drivers/common/mlx5/mlx5_glue.c:281:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2395: FILE: drivers/common/mlx5/mlx5_glue.c:306:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2410: FILE: drivers/common/mlx5/mlx5_glue.c:321:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2427: FILE: drivers/common/mlx5/mlx5_glue.c:338:
+ return ENOTSUP;
total: 8 errors, 7 warnings, 5961 lines checked
parent reply other threads:[~2020-01-28 11:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1580205965-21492-3-git-send-email-matan@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128110746.A7C861C24F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=matan@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).