From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A1C5A04B3 for ; Tue, 28 Jan 2020 12:07:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4416D1C23E; Tue, 28 Jan 2020 12:07:47 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id A7C861C24F; Tue, 28 Jan 2020 12:07:46 +0100 (CET) In-Reply-To: <1580205965-21492-3-git-send-email-matan@mellanox.com> References: <1580205965-21492-3-git-send-email-matan@mellanox.com> To: test-report@dpdk.org Cc: Matan Azrad Message-Id: <20200128110746.A7C861C24F@dpdk.org> Date: Tue, 28 Jan 2020 12:07:46 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw65229 [PATCH v2 02/25] drivers: introduce mlx5 common library X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/65229 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #769: FILE: drivers/common/mlx5/mlx5_common.h:18: +#define PMD_DRV_LOG_OPAREN ( ERROR:SPACING: space prohibited before that close parenthesis ')' #770: FILE: drivers/common/mlx5/mlx5_common.h:19: +#define PMD_DRV_LOG_CPAREN ) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #770: FILE: drivers/common/mlx5/mlx5_common.h:19: +#define PMD_DRV_LOG_CPAREN ) ERROR:SPACING: space prohibited before that ',' (ctx:WxE) #771: FILE: drivers/common/mlx5/mlx5_common.h:20: +#define PMD_DRV_LOG_COMMA , ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #771: FILE: drivers/common/mlx5/mlx5_common.h:20: +#define PMD_DRV_LOG_COMMA , ERROR:SPACING: space required after that ',' (ctx:VxB) #789: FILE: drivers/common/mlx5/mlx5_common.h:38: + RTE_FMT_HEAD(__VA_ARGS__,), \ ^ ERROR:SPACING: space required after that ',' (ctx:VxB) #790: FILE: drivers/common/mlx5/mlx5_common.h:39: + RTE_FMT_TAIL(__VA_ARGS__,))) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #1826: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:956: + void *tx_domain __rte_unused, FILE *file __rte_unused) ^ WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2283: FILE: drivers/common/mlx5/mlx5_glue.c:194: + return ENOTSUP; WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2342: FILE: drivers/common/mlx5/mlx5_glue.c:253: + return ENOTSUP; WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2357: FILE: drivers/common/mlx5/mlx5_glue.c:268: + return ENOTSUP; WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2370: FILE: drivers/common/mlx5/mlx5_glue.c:281: + return ENOTSUP; WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2395: FILE: drivers/common/mlx5/mlx5_glue.c:306: + return ENOTSUP; WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2410: FILE: drivers/common/mlx5/mlx5_glue.c:321: + return ENOTSUP; WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2427: FILE: drivers/common/mlx5/mlx5_glue.c:338: + return ENOTSUP; total: 8 errors, 7 warnings, 5961 lines checked