From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <jerinj@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw65434 [RFC PATCH 2/5] node: add packet processing nodes
Date: Fri, 31 Jan 2020 18:04:51 +0100 (CET) [thread overview]
Message-ID: <20200131170451.E95161C12F@dpdk.org> (raw)
In-Reply-To: <20200131170201.3236153-3-jerinj@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65434
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#637: FILE: lib/librte_node/ethdev_rx_priv.h:30:
+ ETHDEV_RX_NEXT_IP4_LOOKUP,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#638: FILE: lib/librte_node/ethdev_rx_priv.h:31:
+ ETHDEV_RX_NEXT_MAX,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#750: FILE: lib/librte_node/ethdev_tx_priv.h:12:
+ ETHDEV_TX_NEXT_PKT_DROP,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#751: FILE: lib/librte_node/ethdev_tx_priv.h:13:
+ ETHDEV_TX_NEXT_MAX,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#803: FILE: lib/librte_node/ip4_lookup.c:26:
+ struct rte_lpm *lpm_tbl[RTE_MAX_NUMA_NODES];$
ERROR:CODE_INDENT: code indent should use tabs where possible
#812: FILE: lib/librte_node/ip4_lookup.c:35:
+ struct rte_node *node,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#812: FILE: lib/librte_node/ip4_lookup.c:35:
+ struct rte_node *node,$
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#842: FILE: lib/librte_node/ip4_lookup.c:65:
+#define OBJS_PER_CLINE (RTE_CACHE_LINE_SIZE / sizeof (void *))
ERROR:SPACING: space prohibited before that close parenthesis ')'
#865: FILE: lib/librte_node/ip4_lookup.c:88:
+ if (likely(n_left_from >= 7 )) {
WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#944: FILE: lib/librte_node/ip4_lookup.c:167:
+ /* Copy things succesfully speculated till now */
WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#1031: FILE: lib/librte_node/ip4_lookup.c:254:
+ /* Copy things succesfully speculated till now */
ERROR:CODE_INDENT: code indent should use tabs where possible
#1064: FILE: lib/librte_node/ip4_lookup.c:287:
+ struct rte_node *node,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1064: FILE: lib/librte_node/ip4_lookup.c:287:
+ struct rte_node *node,$
ERROR:SPACING: space prohibited before that close parenthesis ')'
#1114: FILE: lib/librte_node/ip4_lookup.c:337:
+ if (likely(n_left_from >= 7 )) {
WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#1211: FILE: lib/librte_node/ip4_lookup.c:434:
+ /* Copy things succesfully speculated till now */
WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#1293: FILE: lib/librte_node/ip4_lookup.c:516:
+ /* Copy things succesfully speculated till now */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1422: FILE: lib/librte_node/ip4_lookup.c:645:
+ .process = ip4_lookup_node_process,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1423: FILE: lib/librte_node/ip4_lookup.c:646:
+ .name = "ip4_lookup",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1425: FILE: lib/librte_node/ip4_lookup.c:648:
+ .init = ip4_lookup_node_init,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1427: FILE: lib/librte_node/ip4_lookup.c:650:
+ .nb_edges = IP4_LOOKUP_NEXT_MAX,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1428: FILE: lib/librte_node/ip4_lookup.c:651:
+ .next_nodes = {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1431: FILE: lib/librte_node/ip4_lookup.c:654:
+ },$
WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#1607: FILE: lib/librte_node/ip4_rewrite.c:144:
+ /* Copy things succesfully speculated till now */
WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#1699: FILE: lib/librte_node/ip4_rewrite.c:236:
+ /* Copy things succesfully speculated till now */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1826: FILE: lib/librte_node/ip4_rewrite_priv.h:17:
+ uint16_t rewrite_len;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1827: FILE: lib/librte_node/ip4_rewrite_priv.h:18:
+ uint16_t tx_node;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1828: FILE: lib/librte_node/ip4_rewrite_priv.h:19:
+ uint16_t enabled;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1829: FILE: lib/librte_node/ip4_rewrite_priv.h:20:
+ uint16_t rsvd;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1830: FILE: lib/librte_node/ip4_rewrite_priv.h:21:
+ union {$
WARNING:TABSTOP: Statements should start on a tabstop
#1832: FILE: lib/librte_node/ip4_rewrite_priv.h:23:
+ struct rte_ether_addr dst;
WARNING:TABSTOP: Statements should start on a tabstop
#1833: FILE: lib/librte_node/ip4_rewrite_priv.h:24:
+ struct rte_ether_addr src;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1836: FILE: lib/librte_node/ip4_rewrite_priv.h:27:
+ };$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1840: FILE: lib/librte_node/ip4_rewrite_priv.h:31:
+ struct ip4_rewrite_nh_header nh[RTE_GRAPH_IP4_REWRITE_MAX_NH];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1842: FILE: lib/librte_node/ip4_rewrite_priv.h:33:
+ uint16_t next_index[RTE_MAX_ETHPORTS];$
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1909: FILE: lib/librte_node/node_private.h:16:
+ RTE_FMT("NODE %s: %s():%u " RTE_FMT_HEAD(__VA_ARGS__,)\
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1911: FILE: lib/librte_node/node_private.h:18:
+ RTE_FMT_TAIL(__VA_ARGS__,)))
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2072: FILE: lib/librte_node/rte_node_ip4_api.h:14:
+ IP4_LOOKUP_NEXT_REWRITE,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2073: FILE: lib/librte_node/rte_node_ip4_api.h:15:
+ IP4_LOOKUP_NEXT_PKT_DROP,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2074: FILE: lib/librte_node/rte_node_ip4_api.h:16:
+ IP4_LOOKUP_NEXT_MAX,$
total: 6 errors, 33 warnings, 1865 lines checked
Warning in /lib/librte_node/ip4_lookup.c:
Using rte_panic/rte_exit
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
parent reply other threads:[~2020-01-31 17:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200131170201.3236153-3-jerinj@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131170451.E95161C12F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jerinj@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).