* [dpdk-test-report] |WARNING| pw66828 [PATCH 1/5] net/iavf: add support for FDIR basic rule
[not found] <1584510121-377747-2-git-send-email-simei.su@intel.com>
@ 2020-03-18 5:44 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-03-18 5:44 UTC (permalink / raw)
To: test-report; +Cc: Simei Su
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66828
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#199: FILE: drivers/net/iavf/iavf_fdir.c:71:
+ {iavf_pattern_ethertype, IAVF_FDIR_INSET_ETH, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#200: FILE: drivers/net/iavf/iavf_fdir.c:72:
+ {iavf_pattern_eth_ipv4, IAVF_FDIR_INSET_ETH_IPV4, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#201: FILE: drivers/net/iavf/iavf_fdir.c:73:
+ {iavf_pattern_eth_ipv4_udp, IAVF_FDIR_INSET_ETH_IPV4_UDP, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#202: FILE: drivers/net/iavf/iavf_fdir.c:74:
+ {iavf_pattern_eth_ipv4_tcp, IAVF_FDIR_INSET_ETH_IPV4_TCP, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#203: FILE: drivers/net/iavf/iavf_fdir.c:75:
+ {iavf_pattern_eth_ipv4_sctp, IAVF_FDIR_INSET_ETH_IPV4_SCTP, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#204: FILE: drivers/net/iavf/iavf_fdir.c:76:
+ {iavf_pattern_eth_ipv6, IAVF_FDIR_INSET_ETH_IPV6, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#205: FILE: drivers/net/iavf/iavf_fdir.c:77:
+ {iavf_pattern_eth_ipv6_udp, IAVF_FDIR_INSET_ETH_IPV6_UDP, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#206: FILE: drivers/net/iavf/iavf_fdir.c:78:
+ {iavf_pattern_eth_ipv6_tcp, IAVF_FDIR_INSET_ETH_IPV6_TCP, IAVF_INSET_NONE},
WARNING:LONG_LINE: line over 90 characters
#207: FILE: drivers/net/iavf/iavf_fdir.c:79:
+ {iavf_pattern_eth_ipv6_sctp, IAVF_FDIR_INSET_ETH_IPV6_SCTP, IAVF_INSET_NONE},
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rss->queue_num <= IAVF_FDIR_MAX_QREGION_SIZE'
#365: FILE: drivers/net/iavf/iavf_fdir.c:237:
+ if (!(rte_is_power_of_2(rss->queue_num) &&
+ (rss->queue_num <= IAVF_FDIR_MAX_QREGION_SIZE))) {
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.action_set.actions[number]'
#403: FILE: drivers/net/iavf/iavf_fdir.c:275:
+ filter_action = &filter->input.rule_cfg.
+ action_set.actions[number];
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.action_set.actions[number]'
#414: FILE: drivers/net/iavf/iavf_fdir.c:286:
+ filter_action = &filter->input.rule_cfg.
+ action_set.actions[number];
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.action_set.actions[number]'
#426: FILE: drivers/net/iavf/iavf_fdir.c:298:
+ filter_action = &filter->input.rule_cfg.
+ action_set.actions[number];
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.action_set.actions[number]'
#446: FILE: drivers/net/iavf/iavf_fdir.c:318:
+ filter_action = &filter->input.rule_cfg.
+ action_set.actions[number];
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#520: FILE: drivers/net/iavf/iavf_fdir.c:392:
+ hdr = &filter->input.rule_cfg.proto_stack.
+ proto_hdr[layer];
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#577: FILE: drivers/net/iavf/iavf_fdir.c:449:
+ hdr = &filter->input.rule_cfg.proto_stack.
+ proto_hdr[layer];
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#596: FILE: drivers/net/iavf/iavf_fdir.c:468:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#601: FILE: drivers/net/iavf/iavf_fdir.c:473:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#606: FILE: drivers/net/iavf/iavf_fdir.c:478:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#611: FILE: drivers/net/iavf/iavf_fdir.c:483:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#616: FILE: drivers/net/iavf/iavf_fdir.c:488:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#634: FILE: drivers/net/iavf/iavf_fdir.c:506:
+ hdr = &filter->input.rule_cfg.proto_stack.
+ proto_hdr[layer];
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#648: FILE: drivers/net/iavf/iavf_fdir.c:520:
+ == rte_cpu_to_be_32(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#651: FILE: drivers/net/iavf/iavf_fdir.c:523:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#656: FILE: drivers/net/iavf/iavf_fdir.c:528:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#661: FILE: drivers/net/iavf/iavf_fdir.c:533:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#668: FILE: drivers/net/iavf/iavf_fdir.c:540:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#675: FILE: drivers/net/iavf/iavf_fdir.c:547:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#692: FILE: drivers/net/iavf/iavf_fdir.c:564:
+ hdr = &filter->input.rule_cfg.proto_stack.
+ proto_hdr[layer];
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#707: FILE: drivers/net/iavf/iavf_fdir.c:579:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#712: FILE: drivers/net/iavf/iavf_fdir.c:584:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#734: FILE: drivers/net/iavf/iavf_fdir.c:606:
+ hdr = &filter->input.rule_cfg.proto_stack.
+ proto_hdr[layer];
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#754: FILE: drivers/net/iavf/iavf_fdir.c:626:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#759: FILE: drivers/net/iavf/iavf_fdir.c:631:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#781: FILE: drivers/net/iavf/iavf_fdir.c:653:
+ hdr = &filter->input.rule_cfg.proto_stack.
+ proto_hdr[layer];
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#795: FILE: drivers/net/iavf/iavf_fdir.c:667:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#800: FILE: drivers/net/iavf/iavf_fdir.c:672:
+ VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(
total: 0 errors, 19 warnings, 18 checks, 945 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-18 5:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1584510121-377747-2-git-send-email-simei.su@intel.com>
2020-03-18 5:44 ` [dpdk-test-report] |WARNING| pw66828 [PATCH 1/5] net/iavf: add support for FDIR basic rule checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).