From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 049F5A0579 for ; Wed, 18 Mar 2020 20:04:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDE9D1C0CA; Wed, 18 Mar 2020 20:04:51 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id C5FE41C0C5; Wed, 18 Mar 2020 20:04:48 +0100 (CET) In-Reply-To: <20200318190241.3150971-14-jerinj@marvell.com> References: <20200318190241.3150971-14-jerinj@marvell.com> To: test-report@dpdk.org Cc: Message-Id: <20200318190448.C5FE41C0C5@dpdk.org> Date: Wed, 18 Mar 2020 20:04:48 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw66862 [PATCH v1 13/32] eal/trace: implement provider payload X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/66862 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #153: FILE: lib/librte_eal/common/include/rte_trace_provider.h:92: +#define __rte_trace_emit_header_generic(t)\ + const uint64_t val = __atomic_load_n(t, __ATOMIC_ACQUIRE);\ + if (likely(!(val & __RTE_TRACE_FIELD_ENABLE_MASK)))\ + return;\ + void *mem = __rte_trace_mem_get(val);\ + if (unlikely(mem == NULL)) \ + return;\ + mem = __rte_trace_emit_ev_header(mem, val) ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects #162: FILE: lib/librte_eal/common/include/rte_trace_provider.h:101: +#define __rte_trace_emit_header_dp(t)\ + if (!rte_trace_is_dp_enabled())\ + return;\ + __rte_trace_emit_header_generic(t); WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #162: FILE: lib/librte_eal/common/include/rte_trace_provider.h:101: +#define __rte_trace_emit_header_dp(t)\ + if (!rte_trace_is_dp_enabled())\ + return;\ + __rte_trace_emit_header_generic(t); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #162: FILE: lib/librte_eal/common/include/rte_trace_provider.h:101: +#define __rte_trace_emit_header_dp(t)\ + if (!rte_trace_is_dp_enabled())\ + return;\ + __rte_trace_emit_header_generic(t); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #167: FILE: lib/librte_eal/common/include/rte_trace_provider.h:106: +#define __rte_trace_emit_datatype(in)\ + memcpy(mem, &(in), sizeof(in));\ + mem = RTE_PTR_ADD(mem, sizeof(in)) ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects #185: FILE: lib/librte_eal/common/include/rte_trace_provider.h:124: +#define rte_trace_ctf_string(in)\ + if (unlikely(in == NULL))\ + return;\ + rte_strscpy(mem, in, __RTE_TRACE_EMIT_STRING_LEN_MAX);\ + mem = RTE_PTR_ADD(mem, __RTE_TRACE_EMIT_STRING_LEN_MAX) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #185: FILE: lib/librte_eal/common/include/rte_trace_provider.h:124: +#define rte_trace_ctf_string(in)\ + if (unlikely(in == NULL))\ + return;\ + rte_strscpy(mem, in, __RTE_TRACE_EMIT_STRING_LEN_MAX);\ + mem = RTE_PTR_ADD(mem, __RTE_TRACE_EMIT_STRING_LEN_MAX) total: 3 errors, 4 warnings, 97 lines checked