Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/67126 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #155: FILE: lib/librte_eal/common/include/rte_trace_provider.h:92: +#define __rte_trace_emit_header_generic(t)\ +void *mem;\ +do {\ + const uint64_t val = __atomic_load_n(t, __ATOMIC_ACQUIRE);\ + if (likely(!(val & __RTE_TRACE_FIELD_ENABLE_MASK)))\ + return;\ + mem = __rte_trace_mem_get(val);\ + if (unlikely(mem == NULL)) \ + return;\ + mem = __rte_trace_emit_ev_header(mem, val);\ +} while (0) ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects #167: FILE: lib/librte_eal/common/include/rte_trace_provider.h:104: +#define __rte_trace_emit_header_dp(t)\ + if (rte_trace_is_dp_enabled())\ + return;\ + __rte_trace_emit_header_generic(t); WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #167: FILE: lib/librte_eal/common/include/rte_trace_provider.h:104: +#define __rte_trace_emit_header_dp(t)\ + if (rte_trace_is_dp_enabled())\ + return;\ + __rte_trace_emit_header_generic(t); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #167: FILE: lib/librte_eal/common/include/rte_trace_provider.h:104: +#define __rte_trace_emit_header_dp(t)\ + if (rte_trace_is_dp_enabled())\ + return;\ + __rte_trace_emit_header_generic(t); WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #192: FILE: lib/librte_eal/common/include/rte_trace_provider.h:129: +#define rte_trace_ctf_string(in)\ +do {\ + if (unlikely(in == NULL))\ + return;\ + rte_strscpy(mem, in, __RTE_TRACE_EMIT_STRING_LEN_MAX);\ + mem = RTE_PTR_ADD(mem, __RTE_TRACE_EMIT_STRING_LEN_MAX);\ +} while (0) total: 1 errors, 4 warnings, 104 lines checked