* [dpdk-test-report] |WARNING| pw67268 [PATCH v2 3/7] net/virtio: add vectorized packed ring Rx function
[not found] <20200327165412.87359-4-yong.liu@intel.com>
@ 2020-03-27 9:19 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-03-27 9:19 UTC (permalink / raw)
To: test-report; +Cc: Marvin Liu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67268
_coding style issues_
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#162: FILE: drivers/net/virtio/virtio_rxtx.c:2332:
+virtio_recv_pkts_packed_vec(void __rte_unused *rx_queue,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#163: FILE: drivers/net/virtio/virtio_rxtx.c:2333:
+ struct rte_mbuf __rte_unused **rx_pkts,
^
CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#198: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#198: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#198: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#198: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#203: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#203: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#203: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#208: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#208: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#208: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#213: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+ for (iter = val; iter < num; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#213: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+ for (iter = val; iter < num; iter++)
total: 3 errors, 0 warnings, 11 checks, 455 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-27 9:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200327165412.87359-4-yong.liu@intel.com>
2020-03-27 9:19 ` [dpdk-test-report] |WARNING| pw67268 [PATCH v2 3/7] net/virtio: add vectorized packed ring Rx function checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).