From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 197A0A0589 for ; Fri, 27 Mar 2020 10:19:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06D061C0B7; Fri, 27 Mar 2020 10:19:42 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 6E2381C0CC; Fri, 27 Mar 2020 10:19:35 +0100 (CET) In-Reply-To: <20200327165412.87359-5-yong.liu@intel.com> References: <20200327165412.87359-5-yong.liu@intel.com> To: test-report@dpdk.org Cc: Marvin Liu Message-Id: <20200327091935.6E2381C0CC@dpdk.org> Date: Fri, 27 Mar 2020 10:19:35 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw67269 [PATCH v2 4/7] net/virtio: reuse packed ring xmit functions X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/67269 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #269: FILE: drivers/net/virtio/virtqueue.h:567: +#define ASSIGN_UNLESS_EQUAL(var, val) do { \ + if ((var) != (val)) \ + (var) = (val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects? #269: FILE: drivers/net/virtio/virtqueue.h:567: +#define ASSIGN_UNLESS_EQUAL(var, val) do { \ + if ((var) != (val)) \ + (var) = (val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_hdr' - possible side-effects? #274: FILE: drivers/net/virtio/virtqueue.h:572: +#define virtqueue_clear_net_hdr(_hdr) do { \ + ASSIGN_UNLESS_EQUAL((_hdr)->csum_start, 0); \ + ASSIGN_UNLESS_EQUAL((_hdr)->csum_offset, 0); \ + ASSIGN_UNLESS_EQUAL((_hdr)->flags, 0); \ + ASSIGN_UNLESS_EQUAL((_hdr)->gso_type, 0); \ + ASSIGN_UNLESS_EQUAL((_hdr)->gso_size, 0); \ + ASSIGN_UNLESS_EQUAL((_hdr)->hdr_len, 0); \ +} while (0) total: 0 errors, 0 warnings, 3 checks, 349 lines checked