automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: ssardar@amd.com
Subject: [dpdk-test-report] |WARNING| pw67740 [PATCH v2] net/axgbe: vlan support enabling in axgbe
Date: Fri,  3 Apr 2020 08:20:58 +0200 (CEST)	[thread overview]
Message-ID: <20200403062058.3AE161C0B2@dpdk.org> (raw)
In-Reply-To: <20200403062001.2728-1-ssardar@amd.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67740

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#172: FILE: drivers/net/axgbe/axgbe_common.h:295:
+#define VLAN_TABLE_BIT(vlan_id)	((unsigned long)1 << ((vlan_id) & 0x3F))

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#660: FILE: drivers/net/axgbe/axgbe_ethdev.h:295:
+	int (*enable_rx_vlan_stripping)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#661: FILE: drivers/net/axgbe/axgbe_ethdev.h:296:
+	int (*disable_rx_vlan_stripping)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#662: FILE: drivers/net/axgbe/axgbe_ethdev.h:297:
+	int (*enable_rx_vlan_filtering)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#663: FILE: drivers/net/axgbe/axgbe_ethdev.h:298:
+	int (*disable_rx_vlan_filtering)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#664: FILE: drivers/net/axgbe/axgbe_ethdev.h:299:
+	int (*update_vlan_hash_table)(struct axgbe_port *);

total: 0 errors, 6 warnings, 0 checks, 529 lines checked

       reply	other threads:[~2020-04-03  6:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200403062001.2728-1-ssardar@amd.com>
2020-04-03  6:20 ` checkpatch [this message]
2020-04-03  8:07 ` [dpdk-test-report] || pw67740 " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403062058.3AE161C0B2@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ssardar@amd.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).