automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <pbhagavatula@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw67756 [PATCH] test: add reassembly perf test
Date: Fri,  3 Apr 2020 13:51:53 +0200 (CEST)	[thread overview]
Message-ID: <20200403115153.4DDFD1C0B7@dpdk.org> (raw)
In-Reply-To: <20200403115026.8735-1-pbhagavatula@marvell.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67756

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#128: FILE: app/test/test_reassembly_perf.c:18:
+#define MAX_FLOWS 1024 * 1024

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#133: FILE: app/test/test_reassembly_perf.c:23:
+#define MAX_PKTS MAX_FLOWS *MAX_FRAGMENTS
                            ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#133: FILE: app/test/test_reassembly_perf.c:23:
+#define MAX_PKTS MAX_FLOWS *MAX_FRAGMENTS

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#136: FILE: app/test/test_reassembly_perf.c:26:
+#define MAX_TTL_MS 5 * MS_PER_S

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#143: FILE: app/test/test_reassembly_perf.c:33:
+#define IP_SRC_ADDR(x) (198U << 24) | (18 << 16) | (0 << 8) | x

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#144: FILE: app/test/test_reassembly_perf.c:34:
+#define IP_DST_ADDR(x) (198U << 24) | (18 << 16) | (1 << 8) | x

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#1099: FILE: app/test/test_reassembly_perf.c:989:
+REGISTER_TEST_COMMAND(reassembly_perf_autotest, test_reassembly_perf);

total: 6 errors, 1 warnings, 1003 lines checked

       reply	other threads:[~2020-04-03 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200403115026.8735-1-pbhagavatula@marvell.com>
2020-04-03 11:51 ` checkpatch [this message]
2020-04-03 13:07 ` [dpdk-test-report] |SUCCESS| pw67756 " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403115153.4DDFD1C0B7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=pbhagavatula@marvell.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).