From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3CE2A0577 for ; Mon, 13 Apr 2020 11:10:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 951CA1BEA6; Mon, 13 Apr 2020 11:10:06 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 2DEAD1BED7; Mon, 13 Apr 2020 11:10:06 +0200 (CEST) In-Reply-To: <1586768952-10554-1-git-send-email-ricudis@niometrics.com> References: <1586768952-10554-1-git-send-email-ricudis@niometrics.com> To: test-report@dpdk.org Cc: Christos Ricudis Message-Id: <20200413091006.2DEAD1BED7@dpdk.org> Date: Mon, 13 Apr 2020 11:10:06 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw68257 [PATCH] eal: Place EAL thread stack in a reserved per-lcore memzone X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/68257 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #76: Reserve a per-lcore 4MB memzone and allocate thread stack of EAL threads there for better NUMA locality of stack-allocated variables WARNING:LONG_LINE: line over 90 characters #104: FILE: lib/librte_eal/linux/eal.c:1233: + snprintf(thread_stack_name, sizeof thread_stack_name, "rte:lcore:%s:%d:threadstack", rte_eal_process_type() == RTE_PROC_PRIMARY ? "p" : "s", i); WARNING:SIZEOF_PARENTHESIS: sizeof thread_stack_name should be sizeof(thread_stack_name) #104: FILE: lib/librte_eal/linux/eal.c:1233: + snprintf(thread_stack_name, sizeof thread_stack_name, "rte:lcore:%s:%d:threadstack", rte_eal_process_type() == RTE_PROC_PRIMARY ? "p" : "s", i); WARNING:LONG_LINE: line over 90 characters #107: FILE: lib/librte_eal/linux/eal.c:1236: + if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #107: FILE: lib/librte_eal/linux/eal.c:1236: + if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) { WARNING:BRACES: braces {} are not necessary for single statement blocks #107: FILE: lib/librte_eal/linux/eal.c:1236: + if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) { + rte_panic("Cannot allocate memzone for thread stack"); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #113: FILE: lib/librte_eal/linux/eal.c:1242: + if (pthread_attr_setstack(&attr, thread_stack, thread_stack_size) < 0) { + rte_panic("Cannot set thread stack "); + } WARNING:LONG_LINE: line over 90 characters #116: FILE: lib/librte_eal/linux/eal.c:1245: + RTE_LOG(DEBUG, EAL, "Thread stack for lcore %d on socket %d set to %p ", i, lcore_config[i].socket_id, thread_stack); total: 1 errors, 7 warnings, 32 lines checked Warning in /lib/librte_eal/linux/eal.c: Using rte_panic/rte_exit